Changeset 18255 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-10-06T19:31:20+02:00 (3 years ago)

Author:

Don-vip

Message:

see #16472 - Fix coverity FB.FE_FLOATING_POINT_EQUALITY and FB.UG_SYNC_SET_UNSYNC_GET (patch by taylor.smock)

Location:

trunk/src/org/openstreetmap/josm/gui/util/imagery

Files:

• CameraPlane.java (modified) (1 diff)
• Vector3D.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/util/imagery/CameraPlane.java

@@ -183 +183 @@
     }
 
-    public Vector3D getRotation() {
+    public synchronized Vector3D getRotation() {
         return this.rotation;
     }

trunk/src/org/openstreetmap/josm/gui/util/imagery/Vector3D.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.util.imagery;
+
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -237 +239 @@
         if (o instanceof Vector3D) {
             Vector3D other = (Vector3D) o;
-            return this.x == other.x && this.y == other.y && this.z == other.z;
+            return Utils.equalsEpsilon(this.x, other.x) && Utils.equalsEpsilon(this.y, other.y) && Utils.equalsEpsilon(this.z, other.z);
         }
         return false;