Changeset 18248 in josm for trunk

Timestamp:

2021-10-05T20:46:07+02:00 (3 years ago)

Author:

Don-vip

Message:

fix #15498 - Load folders containing pictures in separate layers if geoimage.one-layer-per-folder advanced property is set to true

Location:

trunk/src/org/openstreetmap/josm/gui/layer/geoimage

Files:

• GeoImageLayer.java (modified) (1 diff)
• ImagesLoader.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java

@@ -166 +166 @@
      */
     public GeoImageLayer(final List<ImageEntry> data, GpxData gpxData, final String name, boolean useThumbs) {
-        super(name != null ? name : tr("Geotagged Images"));
+        super(!Utils.isBlank(name) ? name : tr("Geotagged Images"));
         this.data = new ImageData(data);
         this.gpxData = gpxData;

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImagesLoader.java

@@ -12 +12 @@
 import java.util.LinkedHashSet;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
+import java.util.TreeMap;
+import java.util.stream.Collectors;
 
 import javax.swing.JOptionPane;
 
+import org.openstreetmap.josm.data.preferences.BooleanProperty;
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.PleaseWaitRunnable;
@@ -34 +38 @@
 
     private boolean canceled;
-    private GeoImageLayer layer;
+    private final List<GeoImageLayer> layers = new ArrayList<>();
     private final Collection<File> selection;
     private final Set<String> loadedDirectories = new HashSet<>();
     private final Set<String> errorMessages;
     private final GpxLayer gpxLayer;
+
+    private static final BooleanProperty PROP_ONE_LAYER_PER_FOLDER = new BooleanProperty("geoimage.one-layer-per-folder", false);
 
     /**
@@ -73 +79 @@
 
         // read the image files
-        List<ImageEntry> entries = new ArrayList<>(files.size());
+        Map<String, List<ImageEntry>> entries = new TreeMap<>();
 
         for (File f : files) {
@@ -86 +92 @@
             ImageEntry e = new ImageEntry(f);
             e.extractExif();
-            entries.add(e);
+            File parentFile = f.getParentFile();
+            entries.computeIfAbsent(parentFile != null ? parentFile.getName() : "", x -> new ArrayList<>()).add(e);
         }
-        layer = new GeoImageLayer(entries, gpxLayer);
+        if (Boolean.TRUE.equals(PROP_ONE_LAYER_PER_FOLDER.get())) {
+            entries.entrySet().stream().map(e -> new GeoImageLayer(e.getValue(), gpxLayer, e.getKey())).forEach(layers::add);
+        } else {
+            layers.add(new GeoImageLayer(entries.values().stream().flatMap(List<ImageEntry>::stream).collect(Collectors.toList()), gpxLayer));
+        }
         files.clear();
     }
@@ -160 +171 @@
                     );
         }
-        if (layer != null) {
+        for (GeoImageLayer layer : layers) {
             MainApplication.getLayerManager().addLayer(layer);