Changeset 18223 in osm for applications/editors/josm

Timestamp:

2009-10-20T21:02:10+02:00 (15 years ago)

Author:

skela

Message:

Fixed #3472 in JOSM Validator: do not complain about unconnected ways
when one of the "ways" is a barrier, a fence or a disused highway.

File:

• applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/tests/UnconnectedWays.java (modified) (4 diffs)

applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/tests/UnconnectedWays.java

@@ -51 +51 @@
     public void startTest(ProgressMonitor monitor)
     {
-        super.startTest(monitor);
+        super.startTest(monitor);
         ways = new HashSet<MyWaySegment>();
         endnodes = new HashSet<Node>();
@@ -162 +162 @@
         private Line2D line;
         public Way w;
-        public Boolean isAbandoned = false;
-        public Boolean isBoundary = false;
-        public Boolean highway;
+        public boolean isAbandoned = false;
+        public boolean isBoundary = false;
+        public boolean highway;
 
         public MyWaySegment(Way w, Node n1, Node n2)
@@ -170 +170 @@
             this.w = w;
             String railway = w.get("railway");
-            this.isAbandoned = railway != null && railway.equals("abandoned");
-            this.highway = w.get("highway") != null || (railway != null && !isAbandoned);
-            this.isBoundary = w.get("boundary") != null && w.get("boundary").equals("administrative") && !this.highway;
+            String highway = w.get("highway");
+            this.isAbandoned = "abandoned".equals(railway) || "yes".equals(w.get("disused"));
+            this.highway = (highway != null || railway != null) && !isAbandoned;
+            this.isBoundary = !this.highway && "administrative".equals(w.get("boundary"));
             line = new Line2D.Double(n1.getEastNorth().east(), n1.getEastNorth().north(),
             n2.getEastNorth().east(), n2.getEastNorth().north());
@@ -193 +194 @@
     public void visit(Way w)
     {
-        if( !w.isUsable() )
+        if (!w.isUsable()
+            || w.get("barrier") != null
+            || "cliff".equals(w.get("natural")))
             return;
+
         int size = w.getNodesCount();
         if(size < 2)