Changeset 18131 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2021-08-10T23:33:40+02:00 (3 years ago)

Author:

Don-vip

Message:

fix #21215 - fix StackOverflowError in ComboBoxHistory (patch by taylor.smock)

File:

• trunk/test/unit/org/openstreetmap/josm/gui/widgets/HistoryComboBoxTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/gui/widgets/HistoryComboBoxTest.java

@@ -45 +45 @@
         assertDoesNotThrow(historyComboBox::addCurrentItemToHistory);
     }
+
+    /**
+     * Non-regression test for JOSM #21215: StackOverflowError
+     */
+    @Test
+    void testNonRegression21215() {
+        final HistoryComboBox historyComboBox = new HistoryComboBox();
+        // utils plugin2 added a listener that pretty much did this
+        historyComboBox.addItemListener(event -> historyComboBox.addCurrentItemToHistory());
+        final AutoCompletionItem testItem = new AutoCompletionItem("testNonRegression21215");
+        // Add the original item
+        historyComboBox.getEditor().setItem(testItem);
+        historyComboBox.addCurrentItemToHistory();
+
+        // add a new item
+        historyComboBox.getEditor().setItem(new AutoCompletionItem("testNonRegression21215_2"));
+        historyComboBox.addCurrentItemToHistory();
+
+        // Readd the first item
+        historyComboBox.getEditor().setItem(testItem);
+        assertDoesNotThrow(historyComboBox::addCurrentItemToHistory);
+    }
 }