Changeset 18075 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-07-19T20:43:01+02:00 (4 years ago)

Author:

Don-vip

Message:

see #2760 - only consider GPX-prefixed tags uninteresting during the "convert to data" simplification process

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/AbstractPrimitive.java (modified) (2 diffs)
• gui/layer/gpx/ConvertToDataLayerAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -23 +23 @@
 import java.util.stream.Stream;
 
-import org.openstreetmap.josm.data.gpx.GpxConstants;
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.Utils;
@@ -799 +798 @@
             List<String> l = new LinkedList<>(Arrays.asList(
                 "source", "source_ref", "source:", "comment",
-                "watch", "watch:", "description", "attribution", GpxConstants.GPX_PREFIX));
+                "watch", "watch:", "description", "attribution"));
             l.addAll(getDiscardableKeys());
             l.addAll(getWorkInProgressKeys());

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ConvertToDataLayerAction.java

@@ -17 +17 @@
 
 import org.openstreetmap.josm.actions.SimplifyWayAction;
+import org.openstreetmap.josm.data.gpx.GpxConstants;
+import org.openstreetmap.josm.data.osm.AbstractPrimitive;
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.Way;
@@ -70 +72 @@
             double err = SimplifyWayAction.askSimplifyWays(ways, tr("Would you like to simplify the ways in the converted layer?"), true);
             if (err > 0) {
-                SimplifyWayAction.simplifyWays(ways, err);
+                try {
+                    // Consider the GPX tags uninteresting temporarily, to make sure it doesn't prevent simplification to remove nodes
+                    AbstractPrimitive.getUninterestingKeys().add(GpxConstants.GPX_PREFIX);
+                    SimplifyWayAction.simplifyWays(ways, err);
+                } finally {
+                    AbstractPrimitive.getUninterestingKeys().remove(GpxConstants.GPX_PREFIX);
+                }
             }
             final OsmDataLayer osmLayer = new OsmDataLayer(ds, tr("Converted from: {0}", layer.getName()), null);