Changeset 17809 in josm for trunk/src

Timestamp:

2021-04-20T23:52:31+02:00 (4 years ago)

Author:

simon04

Message:

see #20745 - Avoid heap allocations in StyleCache

Fixup r17805.

File:

• trunk/src/org/openstreetmap/josm/gui/mappaint/StyleCache.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/mappaint/StyleCache.java

@@ -46 +46 @@
 
         if (selected) {
-            if (s.selectedStyle == null) {
-                s.selectedStyle = new DividedScale<>();
-            }
-            s.selectedStyle.put(o, r);
+            s.selectedStyle = (s.selectedStyle == null ? new DividedScale<StyleElementList>() : s.selectedStyle).put(o, r);
         } else {
-            if (s.plainStyle == null) {
-                s.plainStyle = new DividedScale<>();
-            }
-            s.plainStyle.put(o, r);
+            s.plainStyle = (s.plainStyle == null ? new DividedScale<StyleElementList>() : s.plainStyle).put(o, r);
         }
         return s.intern();
@@ -82 +76 @@
     @Override
     public boolean equals(Object obj) {
-        if (obj == null) {
-            return false;
-        }
-        if (getClass() != obj.getClass()) {
-            return false;
-        }
+        if (obj == null) return false;
+        if (getClass() != obj.getClass()) return false;
         final StyleCache other = (StyleCache) obj;
         return Objects.equals(plainStyle, other.plainStyle) && Objects.equals(selectedStyle, other.selectedStyle);