Changeset 17756 in josm for trunk/src/org

Timestamp:

2021-04-12T07:57:01+02:00 (4 years ago)

Author:

simon04

Message:

see #20745 - Avoid heap allocations due to ValidatorPrefHelper.PREF_OTHER (fix NPE)

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -26 +26 @@
 import org.openstreetmap.josm.data.osm.IPrimitive;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.preferences.BooleanProperty;
 import org.openstreetmap.josm.data.preferences.CachingProperty;
 import org.openstreetmap.josm.data.preferences.sources.SourceEntry;
@@ -60 +61 @@
     private final Map<MapCSSRule, MapCSSTagCheckerAndRule> ruleToCheckMap = new HashMap<>();
     private static final Map<IPrimitive, Area> mpAreaCache = new HashMap<>();
-    private static final CachingProperty<Boolean> PREF_OTHER = ValidatorPrefHelper.PREF_OTHER.cached();
     static final boolean ALL_TESTS = true;
     static final boolean ONLY_SELECTED_TESTS = false;
+
+    /**
+     * Cached version of {@link ValidatorPrefHelper#PREF_OTHER}, see #20745.
+     */
+    private static final CachingProperty<Boolean> PREF_OTHER = new BooleanProperty("validator.other", false).cached();
 
     /**