Changeset 17752 in josm for trunk/test

Timestamp:

2021-04-12T00:16:06+02:00 (4 years ago)

Author:

simon04

Message:

see #20745 - Avoid heap allocations due to BBox in IPrimitive.getBBox

Cache and return an immutable bounding box.

37.75% in MapCSSTagCheckerPerformanceTest#testCity amount to BBox::new via IPrimitive.getBBox

File:

• trunk/test/unit/org/openstreetmap/josm/data/osm/BBoxTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/data/osm/BBoxTest.java

@@ -4 +4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -34 +35 @@
     void testEqualsContract() {
         TestUtils.assumeWorkingEqualsVerifier();
-        EqualsVerifier.forClass(BBox.class).usingGetClass()
+        EqualsVerifier.forClass(BBox.class)
             .suppress(Warning.NONFINAL_FIELDS)
             .verify();
+    }
+
+    /**
+     * Unit test of {@link BBox#equals} method.
+     */
+    @Test
+    void testEquals() {
+        BBox box = new BBox(1, 2, 3, 4);
+        assertEquals(box, box);
+        assertEquals(box, new BBox(box));
+        assertEquals(box, box.toImmutable());
+    }
+
+    /**
+     * Unit test of {@link BBox#toImmutable} method.
+     */
+    @Test
+    void testToImmutable() {
+        assertThrows(UnsupportedOperationException.class, () -> new BBox(1, 2, 3, 4).toImmutable().add(5, 6));
     }