Changeset 17712 in josm for trunk/test

Timestamp:

2021-04-07T22:34:03+02:00 (4 years ago)

Author:

simon04

Message:

see #14176 - Migrate Note/NoteComment to Instant

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• data/notes/NoteCommentTest.java (modified) (2 diffs)
• data/notes/NoteTest.java (modified) (3 diffs)
• gui/dialogs/NotesDialogTest.java (modified) (2 diffs)
• io/NoteReaderTest.java (modified) (2 diffs)
• tools/date/DateUtilsTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/data/notes/NoteCommentTest.java

@@ -6 +6 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import java.util.Date;
+import java.time.Instant;
 
 import org.junit.jupiter.api.extension.RegisterExtension;
@@ -31 +31 @@
     @Test
     void testNoteComment() {
-        NoteComment comment = new NoteComment(new Date(), null, "foo", null, true);
+        NoteComment comment = new NoteComment(Instant.now(), null, "foo", null, true);
         assertEquals("foo", comment.toString());
         assertTrue(comment.isNew());

trunk/test/unit/org/openstreetmap/josm/data/notes/NoteTest.java

@@ -5 +5 @@
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
-import java.util.Date;
+import java.time.Instant;
 
 import org.junit.jupiter.api.extension.RegisterExtension;
@@ -36 +36 @@
         Note note = new Note(LatLon.ZERO);
         assertEquals("Note 0: null", note.toString());
-        note.addComment(new NoteComment(new Date(), null, "foo", null, true));
+        note.addComment(new NoteComment(Instant.now(), null, "foo", null, true));
         assertEquals("Note 0: foo", note.toString());
     }
@@ -65 +65 @@
             .withPrefabValues(LatLon.class, LatLon.ZERO, new LatLon(1, 1))
             .withPrefabValues(NoteComment.class,
-                    new NoteComment(new Date(), null, "foo", null, true),
-                    new NoteComment(new Date(), null, "bar", null, false))
+                    new NoteComment(Instant.now(), null, "foo", null, true),
+                    new NoteComment(Instant.now(), null, "bar", null, false))
             .verify();
     }

trunk/test/unit/org/openstreetmap/josm/gui/dialogs/NotesDialogTest.java

@@ -4 +4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-import java.util.Date;
+import java.time.Instant;
 
 import javax.swing.JLabel;
@@ -35 +35 @@
     void testMultiLineNoteRendering() {
         Note note = new Note(LatLon.ZERO);
-        note.setCreatedAt(new Date());
-        note.addComment(new NoteComment(new Date(), User.createLocalUser(null), "foo\nbar\n\nbaz:\nfoo", null, false));
+        note.setCreatedAt(Instant.now());
+        note.addComment(new NoteComment(Instant.now(), User.createLocalUser(null), "foo\nbar\n\nbaz:\nfoo", null, false));
         assertEquals("0: foo; bar; baz: foo",
                 ((JLabel) new NoteRenderer().getListCellRendererComponent(new JList<>(), note, 0, false, false)).getText());

trunk/test/unit/org/openstreetmap/josm/io/NoteReaderTest.java

@@ -64 +64 @@
         assertEquals(1, list.size());
         Note n = list.get(0);
-        assertEquals(DateUtils.fromString("2013-04-24 08:08:51 UTC"), n.getClosedAt());
-        assertEquals(DateUtils.fromString("2013-04-24 08:07:02 UTC"), n.getCreatedAt());
+        assertEquals(DateUtils.parseInstant("2013-04-24 08:08:51 UTC"), n.getClosedAt());
+        assertEquals(DateUtils.parseInstant("2013-04-24 08:07:02 UTC"), n.getCreatedAt());
         assertEquals(4, n.getId());
         assertEquals(new LatLon(36.7232991, 68.86415), n.getLatLon());
@@ -74 +74 @@
         NoteComment c1 = comments.get(0);
         assertEquals(c1, n.getFirstComment());
-        assertEquals(DateUtils.fromString("2013-04-24 08:07:02 UTC"), c1.getCommentTimestamp());
+        assertEquals(DateUtils.parseInstant("2013-04-24 08:07:02 UTC"), c1.getCommentTimestamp());
         assertEquals(Action.OPENED, c1.getNoteAction());
         assertEquals("test", c1.getText());

trunk/test/unit/org/openstreetmap/josm/tools/date/DateUtilsTest.java

@@ -10 +10 @@
 
 import java.text.DateFormat;
+import java.time.Instant;
+import java.time.format.FormatStyle;
 import java.util.Date;
 import java.util.Random;
@@ -272 +274 @@
         assertNotSame(date, DateUtils.cloneDate(date));
     }
+
+    /**
+     * Unit test of {@link DateUtils#getDateTimeFormatter} method.
+     */
+    @Test
+    void testDateTimeFormatter() {
+        Instant instant = Instant.parse("2006-01-02T15:04:05Z");
+        Boolean iso = DateUtils.PROP_ISO_DATES.get();
+        try {
+            assertNotNull(DateUtils.getDateFormatter(FormatStyle.SHORT).format(instant));
+            assertNotNull(DateUtils.getTimeFormatter(FormatStyle.SHORT).format(instant));
+            assertNotNull(DateUtils.getDateTimeFormatter(FormatStyle.SHORT, FormatStyle.SHORT).format(instant));
+            DateUtils.PROP_ISO_DATES.put(!iso);
+            assertNotNull(DateUtils.getDateFormatter(FormatStyle.SHORT).format(instant));
+            assertNotNull(DateUtils.getTimeFormatter(FormatStyle.SHORT).format(instant));
+            assertNotNull(DateUtils.getDateTimeFormatter(FormatStyle.SHORT, FormatStyle.SHORT).format(instant));
+        } finally {
+            DateUtils.PROP_ISO_DATES.put(iso);
+        }
+    }
 }