Changeset 17706 in josm for trunk

Timestamp:

2021-04-07T20:43:30+02:00 (4 years ago)

Author:

simon04

Message:

fix #19126 - Add display preference "Remember dialog geometries"

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• preferences/display/LafPreference.java (modified) (4 diffs)
• util/WindowGeometry.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/display/LafPreference.java

@@ -37 +37 @@
 import org.openstreetmap.josm.gui.preferences.SubPreferenceSetting;
 import org.openstreetmap.josm.gui.preferences.TabPreferenceSetting;
+import org.openstreetmap.josm.gui.util.WindowGeometry;
 import org.openstreetmap.josm.gui.widgets.FileChooserManager;
 import org.openstreetmap.josm.gui.widgets.JosmComboBox;
@@ -91 +92 @@
     private final JCheckBox dynamicButtons = new JCheckBox(tr("Dynamic buttons in side menus"));
     private final JCheckBox isoDates = new JCheckBox(tr("Display ISO dates"));
+    private final JCheckBox dialogGeometry = new JCheckBox(tr("Remember dialog geometries"));
     private final JCheckBox nativeFileChoosers = new JCheckBox(tr("Use native file choosers (nicer, but do not support file filters)"));
     private final JCheckBox zoomReverseWheel = new JCheckBox(tr("Reverse zoom with mouse wheel"));
@@ -182 +184 @@
         isoDates.setSelected(DateUtils.PROP_ISO_DATES.get());
         panel.add(isoDates, GBC.eop().insets(20, 0, 0, 0));
+
+        dialogGeometry.setSelected(WindowGeometry.GUI_GEOMETRY_ENABLED.get());
+        panel.add(dialogGeometry, GBC.eop().insets(20, 0, 0, 0));
 
         nativeFileChoosers.setToolTipText(
@@ -234 +239 @@
         Config.getPref().putBoolean(ToggleDialog.PROP_DYNAMIC_BUTTONS.getKey(), dynamicButtons.isSelected());
         Config.getPref().putBoolean(DateUtils.PROP_ISO_DATES.getKey(), isoDates.isSelected());
+        WindowGeometry.GUI_GEOMETRY_ENABLED.put(dialogGeometry.isSelected());
         Config.getPref().putBoolean(FileChooserManager.PROP_USE_NATIVE_FILE_DIALOG.getKey(), nativeFileChoosers.isSelected());
         MapMover.PROP_ZOOM_REVERSE_WHEEL.put(zoomReverseWheel.isSelected());

trunk/src/org/openstreetmap/josm/gui/util/WindowGeometry.java

@@ -21 +21 @@
 import javax.swing.JComponent;
 
+import org.openstreetmap.josm.data.preferences.BooleanProperty;
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.spi.preferences.Config;
@@ -39 +40 @@
      */
     public static final String PREF_KEY_GUI_GEOMETRY = "gui.geometry";
+
+    /**
+     * Whether storing/restoring of geometries to/from preferences is enabled
+     */
+    public static final BooleanProperty GUI_GEOMETRY_ENABLED = new BooleanProperty(PREF_KEY_GUI_GEOMETRY + ".enabled", true);
 
     /** the top left point */
@@ -214 +220 @@
 
     protected final void initFromPreferences(String preferenceKey) throws WindowGeometryException {
+        if (!GUI_GEOMETRY_ENABLED.get()) {
+            throw new WindowGeometryException("window geometry from preferences is disabled");
+        }
         String value = Config.getPref().get(preferenceKey);
         if (value.isEmpty())