Changeset 17667 in josm

Timestamp:

2021-03-25T22:58:47+01:00 (4 years ago)

Author:

simon04

Message:

fix #15397 - Toolbar: make ToggleAction buttons reflect toggle state

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/PreferenceToggleAction.java (modified) (1 diff)
• gui/preferences/ToolbarPreferences.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/PreferenceToggleAction.java

@@ -18 +18 @@
  * register another {@link PreferenceChangedListener} for the given preference key.
  */
-public class PreferenceToggleAction extends JosmAction implements PreferenceChangedListener {
+public class PreferenceToggleAction extends ToggleAction implements PreferenceChangedListener {
 
     private final JCheckBoxMenuItem checkbox;

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -32 +32 @@
 
 import javax.swing.AbstractAction;
+import javax.swing.AbstractButton;
 import javax.swing.Action;
 import javax.swing.DefaultListCellRenderer;
@@ -68 +69 @@
 import org.openstreetmap.josm.actions.ParameterizedAction;
 import org.openstreetmap.josm.actions.ParameterizedActionDecorator;
+import org.openstreetmap.josm.actions.ToggleAction;
 import org.openstreetmap.josm.data.imagery.ImageryInfo;
 import org.openstreetmap.josm.data.imagery.ImageryLayerInfo;
+import org.openstreetmap.josm.gui.IconToggleButton;
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.MapFrame;
@@ -1170 +1173 @@
                 control.addSeparator();
             } else {
-                final JButton b = addButtonAndShortcut(action);
+                final AbstractButton b = addButtonAndShortcut(action);
                 buttonActions.put(b, action);
 
@@ -1230 +1233 @@
     }
 
-    private JButton addButtonAndShortcut(ActionDefinition action) {
+    private AbstractButton addButtonAndShortcut(ActionDefinition action) {
         Action act = action.getParametrizedAction();
-        JButton b = control.add(act);
+        final AbstractButton b;
+        if (act instanceof ToggleAction) {
+            b = new IconToggleButton(act);
+            control.add(b);
+        } else {
+            b = control.add(act);
+        }
 
         Shortcut sc = null;