Changeset 17618 in josm for trunk

Timestamp:

2021-03-21T13:56:19+01:00 (4 years ago)

Author:

simon04

Message:

see #4626 - PerformanceTestUtils.PerformanceTestTimer: use Stopwatch

Location:

trunk

Files:

• src/org/openstreetmap/josm/tools/Stopwatch.java (modified) (2 diffs)
• test/performance/org/openstreetmap/josm/PerformanceTestUtils.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/tools/Stopwatch.java

@@ -23 +23 @@
      */
     public static Stopwatch createStarted() {
-        return new Stopwatch(System.currentTimeMillis());
+        return new Stopwatch(System.nanoTime());
     }
 
@@ -32 +32 @@
      */
     public long elapsed() {
-        return System.currentTimeMillis() - start;
+        return (System.nanoTime() - start) / 1_000_000;
     }
 

trunk/test/performance/org/openstreetmap/josm/PerformanceTestUtils.java

@@ -16 +16 @@
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import org.openstreetmap.josm.tools.Stopwatch;
 
 /**
@@ -44 +45 @@
 
     /**
-     * A helper class that captures the time from object creation until #done() was called.
-     * @author Michael Zangl
-     */
-    public static class PerformanceTestTimerCapture {
-        private final long time;
-
-        protected PerformanceTestTimerCapture() {
-            time = System.nanoTime();
-        }
-
-        /**
-         * Get the time since this object was created.
-         * @return The time.
-         */
-        public long getTimeSinceCreation() {
-            return (System.nanoTime() - time) / 1000000;
-        }
-    }
-
-    /**
      * A timer that measures the time from it's creation to the {@link #done()} call.
      * @author Michael Zangl
      */
-    public static class PerformanceTestTimer extends PerformanceTestTimerCapture {
+    public static class PerformanceTestTimer {
+        private final Stopwatch stopwatch = Stopwatch.createStarted();
         private final String name;
         private boolean measurementPlotsPlugin = true;
@@ -87 +69 @@
          */
         public void done() {
-            long dTime = getTimeSinceCreation();
+            long dTime = stopwatch.elapsed();
             if (measurementPlotsPlugin) {
                 measurementPlotsPluginOutput(name + "(ms)", dTime);
@@ -120 +102 @@
         for (int i = 0; i < TIMES_WARMUP; i++) {
             cleanSystem();
-            PerformanceTestTimerCapture capture = new PerformanceTestTimerCapture();
+            Stopwatch capture = Stopwatch.createStarted();
             testRunner.run();
-            capture.getTimeSinceCreation();
+            capture.elapsed();
         }
         ArrayList<Long> times = new ArrayList<>();
         for (int i = 0; i < TIMES_RUN; i++) {
             cleanSystem();
-            PerformanceTestTimerCapture capture = new PerformanceTestTimerCapture();
+            Stopwatch stopwatch = Stopwatch.createStarted();
             testRunner.run();
-            times.add(capture.getTimeSinceCreation());
+            times.add(stopwatch.elapsed());
         }
         System.out.println(times);