Changeset 17605 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-03-20T15:53:51+01:00 (4 years ago)

Author:

simon04

Message:

fix #19554 - Tagging presets: Icons for all preset input boxes

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• tagging/presets/items/Check.java (modified) (3 diffs)
• tagging/presets/items/ComboMultiSelect.java (modified) (1 diff)
• tagging/presets/items/Label.java (modified) (2 diffs)
• tagging/presets/items/Link.java (modified) (2 diffs)
• tagging/presets/items/Text.java (modified) (1 diff)
• tagging/presets/items/TextItem.java (modified) (3 diffs)
• widgets/UrlLabel.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Check.java

@@ -10 +10 @@
 import java.util.List;
 
-import javax.swing.ImageIcon;
 import javax.swing.JLabel;
 import javax.swing.JPanel;
-import javax.swing.SwingConstants;
 
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.OsmUtils;
 import org.openstreetmap.josm.data.osm.Tag;
-import org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader;
 import org.openstreetmap.josm.gui.widgets.QuadStateCheckBox;
 import org.openstreetmap.josm.tools.GBC;
@@ -96 +93 @@
             JPanel checkPanel = new JPanel(new GridBagLayout());
             checkPanel.add(check, GBC.std());
-            JLabel label = new JLabel(locale_text, getIcon(), SwingConstants.LEFT);
+            JLabel label = new JLabel(locale_text);
+            addIcon(label);
             label.addMouseListener(new MouseAdapter() {
                 @Override
@@ -129 +127 @@
     }
 
-    /**
-     * Returns the entry icon, if any.
-     * @return the entry icon, or {@code null}
-     * @since 15437
-     */
-    public ImageIcon getIcon() {
-        return icon == null ? null : loadImageIcon(icon, TaggingPresetReader.getZipIcons(), (int) icon_size);
-    }
-
     @Override
     public Collection<String> getValues() {

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/ComboMultiSelect.java

@@ -216 +216 @@
 
         final JLabel label = new JLabel(tr("{0}:", locale_text));
+        addIcon(label);
         label.setToolTipText(getKeyTooltipText());
         label.setComponentPopupMenu(getPopupMenu());

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Label.java

@@ -4 +4 @@
 import java.util.Collection;
 
-import javax.swing.Icon;
-import javax.swing.ImageIcon;
 import javax.swing.JLabel;
 import javax.swing.JPanel;
 
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
-import org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader;
 import org.openstreetmap.josm.tools.GBC;
 
@@ -18 +15 @@
 public class Label extends TextItem {
 
-    /** The location of icon file to display (optional) */
-    public String icon; // NOSONAR
-    /** The size of displayed icon. If not set, default is 16px */
-    public short icon_size = 16; // NOSONAR
-
     @Override
     public boolean addToPanel(JPanel p, Collection<OsmPrimitive> sel, boolean presetInitiallyMatches) {
         initializeLocaleText(null);
-        addLabel(p, getIcon(), locale_text);
+        JLabel label = new JLabel(locale_text);
+        addIcon(label);
+        p.add(label, GBC.eol().fill(GBC.HORIZONTAL));
         return true;
     }
 
-    /**
-     * Adds a new {@code JLabel} to the given panel.
-     * @param p The panel
-     * @param icon the icon (optional, can be null)
-     * @param label The text label
-     */
-    public static void addLabel(JPanel p, Icon icon, String label) {
-        p.add(new JLabel(label, icon, JLabel.LEADING), GBC.eol().fill(GBC.HORIZONTAL));
-    }
-
-    /**
-     * Returns the label icon, if any.
-     * @return the label icon, or {@code null}
-     */
-    public ImageIcon getIcon() {
-        return icon == null ? null : loadImageIcon(icon, TaggingPresetReader.getZipIcons(), (int) icon_size);
-    }
 }

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Link.java

@@ -44 +44 @@
         final String url = getUrl();
         if (wiki != null) {
-            return new UrlLabel(url, locale_text, 2) {
+            UrlLabel urlLabel = new UrlLabel(url, locale_text, 2) {
                 @Override
                 public void mouseClicked(MouseEvent e) {
@@ -57 +57 @@
                 }
             };
+            addIcon(urlLabel);
+            return urlLabel;
         } else if (href != null || locale_href != null) {
-            return new UrlLabel(url, locale_text, 2);
+            UrlLabel urlLabel = new UrlLabel(url, locale_text, 2);
+            addIcon(urlLabel);
+            return urlLabel;
         }
         return null;

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Text.java

@@ -164 +164 @@
             value = pnl;
         }
-        final JLabel label = new JLabel(locale_text + ':');
+        final JLabel label = new JLabel(tr("{0}:", locale_text));
+        addIcon(label);
         label.setToolTipText(getKeyTooltipText());
         label.setComponentPopupMenu(getPopupMenu());

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/TextItem.java

@@ -6 +6 @@
 import org.openstreetmap.josm.data.osm.Tag;
 import org.openstreetmap.josm.gui.tagging.presets.TaggingPresetItem;
+import org.openstreetmap.josm.gui.tagging.presets.TaggingPresetReader;
+
+import javax.swing.ImageIcon;
+import javax.swing.JLabel;
+import javax.swing.SwingConstants;
 
 /**
@@ -21 +26 @@
     /** The localized version of {@link #text} */
     public String locale_text; // NOSONAR
+
+    /** The location of icon file to display */
+    public String icon; // NOSONAR
+    /** The size of displayed icon. If not set, default is 16px */
+    public short icon_size = 16; // NOSONAR
+
 
     protected final void initializeLocaleText(String defaultText) {
@@ -39 +50 @@
     }
 
+    /**
+     * Defines the label icon from this entry's icon
+     * @param label the component
+     * @since 17605
+     */
+    protected void addIcon(JLabel label) {
+        label.setIcon(getIcon());
+        label.setHorizontalAlignment(SwingConstants.LEADING);
+    }
+
+    /**
+     * Returns the entry icon, if any.
+     * @return the entry icon, or {@code null}
+     * @since 17605
+     */
+    public ImageIcon getIcon() {
+        return icon == null ? null : loadImageIcon(icon, TaggingPresetReader.getZipIcons(), (int) icon_size);
+    }
+
     @Override
     public String toString() {

trunk/src/org/openstreetmap/josm/gui/widgets/UrlLabel.java

@@ -60 +60 @@
 
     /**
-     * Constructs a new {@code UrlLabel} for the given URL, description and font increase.
+     * Constructs a new {@code UrlLabel} for the given URL, description and image.
      * @param url The URL to use
      * @param description The description to display