Changeset 17584 in josm

Timestamp:

2021-03-18T00:57:06+01:00 (4 years ago)

Author:

simon04

Message:

see #20613 - Introduce Tagged.keys()

Avoids creating a temporary HashMap just for iteration purposes

Location:

trunk

Files:

• src/org/openstreetmap/josm/actions/upload/DiscardTagsHook.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java (modified) (2 diffs)
• src/org/openstreetmap/josm/data/osm/DefaultNameFormatter.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) (3 diffs)
• src/org/openstreetmap/josm/data/osm/Tagged.java (modified) (2 diffs)
• src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java (modified) (3 diffs)
• src/org/openstreetmap/josm/data/validation/tests/Lanes.java (modified) (1 diff)
• src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/conflict/pair/tags/TagMergeModel.java (modified) (2 diffs)
• src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/mappaint/mapcss/ConditionFactory.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/data/osm/OsmPrimitiveKeyHandlingTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/upload/DiscardTagsHook.java

@@ -27 +27 @@
         Collection<String> discardableKeys = new HashSet<>(AbstractPrimitive.getDiscardableKeys());
 
-        boolean needsChange = objectsToUpload.stream().flatMap(osm -> osm.keySet().stream())
+        boolean needsChange = objectsToUpload.stream().flatMap(AbstractPrimitive::keys)
                 .anyMatch(discardableKeys::contains);
 

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -19 +19 @@
 import java.util.concurrent.TimeUnit;
 import java.util.function.BiPredicate;
+import java.util.stream.IntStream;
+import java.util.stream.Stream;
 
 import org.openstreetmap.josm.data.gpx.GpxConstants;
@@ -657 +659 @@
         }
         return result;
+    }
+
+    @Override
+    public Stream<String> keys() {
+        final String[] k = this.keys;
+        if (k == null) {
+            return Stream.empty();
+        } else if (k.length == 1) {
+            return Stream.of(k[0]);
+        } else {
+            return IntStream.range(0, k.length / 2).mapToObj(i -> k[i * 2]);
+        }
     }
 

trunk/src/org/openstreetmap/josm/data/osm/DefaultNameFormatter.java

@@ -454 +454 @@
                 return relation.getName();
         } else if (":LocationCode".equals(nameTag)) {
-            return relation.keySet().stream()
+            return relation.keys()
                     .filter(m -> m.endsWith(nameTag))
                     .findFirst()

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -5 +5 @@
 
 import java.text.MessageFormat;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -570 +569 @@
         // 'area' is not really uninteresting (putting it in that list may have unpredictable side effects)
         // but it's clearly not enough to consider an object as tagged (see #9261)
-        updateFlagsNoLock(FLAG_TAGGED, keySet().stream()
+        updateFlagsNoLock(FLAG_TAGGED, keys()
                 .anyMatch(key -> !isUninterestingKey(key) && !"area".equals(key)));
     }
 
     private void updateAnnotated() {
-        updateFlagsNoLock(FLAG_ANNOTATED, keySet().stream()
-                .anyMatch(getWorkInProgressKeys()::contains));
+        updateFlagsNoLock(FLAG_ANNOTATED, hasKeys() && getWorkInProgressKeys().stream().anyMatch(this::hasKey));
     }
 
@@ -1072 +1070 @@
     @Override
     public Collection<String> getTemplateKeys() {
-        Collection<String> keySet = keySet();
-        List<String> result = new ArrayList<>(keySet.size() + 2);
-        result.add(SPECIAL_VALUE_ID);
-        result.add(SPECIAL_VALUE_LOCAL_NAME);
-        result.addAll(keySet);
-        return result;
+        return Stream.concat(Stream.of(SPECIAL_VALUE_ID, SPECIAL_VALUE_LOCAL_NAME), keys())
+                .collect(Collectors.toList());
     }
 

trunk/src/org/openstreetmap/josm/data/osm/Tagged.java

@@ -6 +6 @@
 import java.util.Map;
 import java.util.Objects;
+import java.util.stream.Stream;
 
 /**
@@ -186 +187 @@
      *
      * @return the set of keys
+     * @see #keys()
      */
     Collection<String> keySet();
+
+    /**
+     * Replies the keys as stream
+     *
+     * @return the keys as stream
+     * @see #keySet()
+     * @since 17584
+     */
+    default Stream<String> keys() {
+        return keySet().stream();
+    }
 
     /**

trunk/src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java

@@ -739 +739 @@
                     // But since we're doing a regex match we'll have to loop over all the keys to see if they match our regex,
                     // and only then try to match against the value
-                    return osm.keySet().stream()
+                    return osm.keys()
                             .anyMatch(k -> keyPattern.matcher(k).find() && valuePattern.matcher(osm.get(k)).find());
                 }
@@ -760 +760 @@
                 mv = osm.get(key);
                 if (!caseSensitive && mv == null) {
-                    mv = osm.keySet().stream().filter(key::equalsIgnoreCase).findFirst().map(osm::get).orElse(null);
+                    mv = osm.keys().filter(key::equalsIgnoreCase).findFirst().map(osm::get).orElse(null);
                 }
             }
@@ -972 +972 @@
             case ANY_VALUE_REGEXP:
             case EXACT_REGEXP:
-                return osm.keySet().stream().anyMatch(k -> keyPattern.matcher(k).matches()
+                return osm.keys().anyMatch(k -> keyPattern.matcher(k).matches()
                         && (mode == Mode.ANY_VALUE_REGEXP || valuePattern.matcher(osm.get(k)).matches()));
             case MISSING_KEY_REGEXP:
-                return osm.keySet().stream().noneMatch(k -> keyPattern.matcher(k).matches());
+                return osm.keys().noneMatch(k -> keyPattern.matcher(k).matches());
             }
             throw new AssertionError("Missed state");

trunk/src/org/openstreetmap/josm/data/validation/tests/Lanes.java

@@ -42 +42 @@
     protected void checkNumberOfLanesByKey(final OsmPrimitive p, String lanesKey, String message) {
         final Set<Integer> lanesCount =
-                p.keySet().stream()
+                p.keys()
                 .filter(x -> x.endsWith(":" + lanesKey))
                 .filter(x -> !Arrays.asList(BLACKLIST).contains(x))

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -690 +690 @@
 
     private void checkMultipolygonTags(OsmPrimitive p) {
-        if (p.isAnnotated() || p.keySet().stream()
+        if (p.isAnnotated() || p.keys()
                 .anyMatch(k -> k.matches("^(abandoned|construction|demolished|disused|planned|razed|removed|was).*")))
             return;

trunk/src/org/openstreetmap/josm/gui/conflict/pair/tags/TagMergeModel.java

@@ -8 +8 @@
 import java.util.List;
 import java.util.Set;
+import java.util.stream.Collectors;
 import java.util.stream.IntStream;
+import java.util.stream.Stream;
 
 import javax.swing.table.DefaultTableModel;
@@ -101 +103 @@
     public void populate(OsmPrimitive my, OsmPrimitive their) {
         tagMergeItems.clear();
-        Set<String> keys = new HashSet<>();
-        keys.addAll(my.keySet());
-        keys.addAll(their.keySet());
+        Set<String> keys = Stream.concat(my.keys(), their.keys()).collect(Collectors.toSet());
         for (String key : keys) {
             String myValue = my.get(key);

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -832 +832 @@
 
     private static boolean containsOnlyGpxTags(Tagged t) {
-        return t.getKeys().keySet().stream()
+        return t.keys()
                 .allMatch(key -> GpxConstants.WPT_KEYS.contains(key) || key.startsWith(GpxConstants.GPX_PREFIX));
     }

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ConditionFactory.java

@@ -556 +556 @@
                     return e.osm.isKeyFalse(label) ^ negateResult;
                 case REGEX:
-                    return e.osm.keySet().stream().anyMatch(containsPattern) ^ negateResult;
+                    return e.osm.keys().anyMatch(containsPattern) ^ negateResult;
                 default:
                     return e.osm.hasKey(label) ^ negateResult;
@@ -580 +580 @@
             String key = label;
             if (KeyMatchType.REGEX == matchType) {
-                key = p.keySet().stream().filter(containsPattern).findAny().orElse(key);
+                key = p.keys().filter(containsPattern).findAny().orElse(key);
             }
             return new Tag(key, p.get(key));

trunk/test/unit/org/openstreetmap/josm/data/osm/OsmPrimitiveKeyHandlingTest.java

@@ -163 +163 @@
         assertEquals(expectedSize, p.getKeys().size());
         assertEquals(expectedSize, p.keySet().size());
+        assertEquals(expectedSize, p.keys().count());
         assertEquals(expectedSize, p.getKeys().entrySet().size());
         assertEquals(expectedSize, p.getKeys().keySet().size());