Changeset 17559 in josm for trunk

Timestamp:

2021-03-13T01:44:36+01:00 (4 years ago)

Author:

Don-vip

Message:

fix #20587 - fix potential infinite loop in QuadBuckets toArray (patch by taylor.smock)

File:

• trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java

@@ -455 +455 @@
     @Override
     public Object[] toArray() {
-        return this.toList().toArray();
+        // Don't call toList() -- in some cases, this can produce an infinite loop
+        // For example, ArrayList may call toArray to get the initial array. However, since we are
+        // creating a new ArrayList in toList with `this`, this creates an infinite recursion loop.
+        // So a `toArray` call becomes `toArray -> toList -> toArray -> toList -> toArray -> ...`
+        // For more information, see #20587.
+        return this.stream().toArray();
     }