Changeset 17541 in josm

Timestamp:

2021-02-24T22:44:13+01:00 (4 years ago)

Author:

Don-vip

Message:

see #16567 - better synchronization of Preferences.settingsMap

File:

• trunk/src/org/openstreetmap/josm/data/Preferences.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -518 +518 @@
      * @throws IOException if any I/O error occurs
      */
-    public void fromXML(Reader in) throws XMLStreamException, IOException {
+    public synchronized void fromXML(Reader in) throws XMLStreamException, IOException {
         PreferencesReader reader = new PreferencesReader(in, false);
         reader.parse();
@@ -529 +529 @@
      * @param reset if {@code true}, current settings file is replaced by the default one
      */
-    public void init(boolean reset) {
+    public synchronized void init(boolean reset) {
         initSuccessful = false;
         // get the preferences.
@@ -671 +671 @@
      * Reset all values stored in this map to the default values. This clears the preferences.
      */
-    public final void resetToDefault() {
+    public final synchronized void resetToDefault() {
         settingsMap.clear();
     }
@@ -683 +683 @@
      */
     @Override
-    public boolean putSetting(final String key, Setting<?> setting) {
+    public synchronized boolean putSetting(final String key, Setting<?> setting) {
         CheckParameterUtil.ensureParameterNotNull(key);
         if (setting != null && setting.getValue() == null)
@@ -816 +816 @@
      * @return XML
      */
-    public String toXML(boolean nopass) {
+    public synchronized String toXML(boolean nopass) {
         return toXML(settingsMap.entrySet(), nopass, false);
     }