Changeset 17521 in josm

Timestamp:

2021-02-22T00:40:49+01:00 (4 years ago)

Author:

Don-vip

Message:

spotbugs - SBSC_USE_STRINGBUFFER_CONCATENATION

File:

• trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -20 +20 @@
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Locale;
@@ -25 +26 @@
 import java.util.Map.Entry;
 import java.util.Optional;
+import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -345 +347 @@
      */
     private static String getCommentWithDataSetHashTag(String comment, DataSet dataSet) {
-        String result = comment;
+        StringBuilder result = new StringBuilder(comment);
         if (dataSet != null) {
             String hashtags = dataSet.getChangeSetTags().get("hashtags");
             if (hashtags != null) {
+                Set<String> sanitizedHashtags = new LinkedHashSet<>();
                 for (String hashtag : hashtags.split(";", -1)) {
-                    String sanitizedHashtag = hashtag.startsWith("#") ? hashtag : "#" + hashtag;
-                    if (!result.contains(sanitizedHashtag)) {
-                        result = result + " " + sanitizedHashtag;
-                    }
+                    sanitizedHashtags.add(hashtag.startsWith("#") ? hashtag : "#" + hashtag);
                 }
-            }
-        }
-        return result;
+                if (!sanitizedHashtags.isEmpty()) {
+                    result.append(' ').append(String.join(" ", sanitizedHashtags));
+                }
+            }
+        }
+        return result.toString();
     }