Changeset 17455 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-01-11T11:54:27+01:00 (4 years ago)

Author:

GerdP

Message:

see #17184: Memory leaks

• don't keep ref to primitives, it isn't needed anywhere

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/InspectPrimitiveDialog.java

@@ -56 +56 @@
 public class InspectPrimitiveDialog extends ExtendedDialog {
 
-    protected transient List<IPrimitive> primitives;
     private boolean mappaintTabLoaded;
     private boolean editcountTabLoaded;
@@ -68 +67 @@
     public InspectPrimitiveDialog(final Collection<? extends IPrimitive> primitives, OsmData<?, ?, ?, ?> data) {
         super(MainApplication.getMainFrame(), tr("Advanced object info"), tr("Close"));
-        this.primitives = new ArrayList<>(primitives);
         setRememberWindowGeometry(getClass().getName() + ".geometry",
                 WindowGeometry.centerInWindow(MainApplication.getMainFrame(), new Dimension(750, 550)));
@@ -75 +73 @@
         final JTabbedPane tabs = new JTabbedPane();
 
-        tabs.addTab(tr("data"), genericMonospacePanel(new JPanel(), buildDataText(data, this.primitives)));
+        tabs.addTab(tr("data"), genericMonospacePanel(new JPanel(), buildDataText(data, new ArrayList<>(primitives))));
 
         final JPanel pMapPaint = new JPanel();