Changeset 17347 in josm for trunk

Timestamp:

2020-11-24T07:00:30+01:00 (4 years ago)

Author:

GerdP

Message:

fix #17196: Undo/Redo may change data in inactive layer

• use separate stacks for each edit layer
• show empty undo/redo stack when active layer isn't an edit layer

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/UndoRedoHandler.java (modified) (6 diffs)
• src/org/openstreetmap/josm/gui/dialogs/CommandStackDialog.java (modified) (4 diffs)
• test/unit/org/openstreetmap/josm/gui/dialogs/CommandStackDialogTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java

@@ -4 +4 @@
 import java.util.Collections;
 import java.util.EventObject;
+import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
+import java.util.Map;
 import java.util.Objects;
 
@@ -11 +13 @@
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.OsmDataManager;
+import org.openstreetmap.josm.gui.MainApplication;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.spi.preferences.Config;
@@ -41 +45 @@
 
     private static class InstanceHolder {
-        static final UndoRedoHandler INSTANCE = new UndoRedoHandler();
+        static final UndoRedoHandler NO_DATA_SET_INSTANCE = new UndoRedoHandler();
+        static final Map<DataSet, UndoRedoHandler> map = new HashMap<>();
+
     }
 
@@ -50 +56 @@
      */
     public static UndoRedoHandler getInstance() {
-        return InstanceHolder.INSTANCE;
+        OsmDataLayer editLayer = MainApplication.getLayerManager().getEditLayer();
+        if (editLayer != null) {
+            if (editLayer == MainApplication.getLayerManager().getActiveLayer()) {
+                return InstanceHolder.map.computeIfAbsent(editLayer.data, k -> new UndoRedoHandler());
+            }
+        }
+        return InstanceHolder.NO_DATA_SET_INSTANCE;
     }
 
@@ -433 +445 @@
             l.commandChanged(commands.size(), redoCommands.size());
         }
+        if (getInstance() != InstanceHolder.NO_DATA_SET_INSTANCE) {
+            for (final CommandQueueListener l : InstanceHolder.NO_DATA_SET_INSTANCE.listenerCommands) {
+                l.commandChanged(commands.size(), redoCommands.size());
+            }
+
+        }
     }
 
@@ -457 +475 @@
         if (dataSet == null)
             return;
-        boolean changed = false;
-        changed |= commands.removeIf(c -> c.getAffectedDataSet() == dataSet);
-        changed |= redoCommands.removeIf(c -> c.getAffectedDataSet() == dataSet);
-        if (changed) {
+        if (InstanceHolder.map.remove(dataSet) != null) {
+            redoCommands.clear();
+            commands.clear();
             fireEvent(new CommandQueueCleanedEvent(this, dataSet));
             fireCommandsChanged();

trunk/src/org/openstreetmap/josm/gui/dialogs/CommandStackDialog.java

@@ -51 +51 @@
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.SideButton;
+import org.openstreetmap.josm.gui.layer.MainLayerManager.ActiveLayerChangeEvent;
+import org.openstreetmap.josm.gui.layer.MainLayerManager.ActiveLayerChangeListener;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.widgets.PopupMenuLauncher;
@@ -63 +65 @@
  * @since 94
  */
-public class CommandStackDialog extends ToggleDialog implements CommandQueuePreciseListener {
+public class CommandStackDialog extends ToggleDialog implements CommandQueuePreciseListener, ActiveLayerChangeListener {
 
     private final DefaultTreeModel undoTreeModel = new DefaultTreeModel(new DefaultMutableTreeNode());
@@ -145 +147 @@
         InputMapUtils.addEnterAction(undoTree, selectAndZoomAction);
         InputMapUtils.addEnterAction(redoTree, selectAndZoomAction);
+        MainApplication.getLayerManager().addActiveLayerChangeListener(this);
     }
 
@@ -553 +556 @@
         }
     }
+
+    @Override
+    public void activeOrEditLayerChanged(ActiveLayerChangeEvent e) {
+        hideNotify();
+        showNotify();
+    }
 }

trunk/test/unit/org/openstreetmap/josm/gui/dialogs/CommandStackDialogTest.java

@@ -28 +28 @@
     @RegisterExtension
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().main().projection();
+    public JOSMTestRules test = new JOSMTestRules().main().projection().preferences();
 
     /**