Changeset 17307 in josm for trunk/src

Timestamp:

2020-11-10T18:06:57+01:00 (4 years ago)

Author:

GerdP

Message:

see #7548: Re-organize the preference dialog

• move code for expert toggle into expertChanged() and make sure that a tab is selected
• always use SwingUtilities.invokeLater() when the PreferenceDialog should be opened with a special tab

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/PreferencesAction.java (modified) (2 diffs)
• gui/dialogs/ToggleDialog.java (modified) (1 diff)
• gui/preferences/PreferenceTabbedPane.java (modified) (2 diffs)
• gui/preferences/ToolbarPreferences.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/PreferencesAction.java

@@ -7 +7 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
+
+import javax.swing.SwingUtilities;
 
 import org.openstreetmap.josm.gui.MainApplication;
@@ -106 +108 @@
     public void run() {
         final PreferenceDialog p = new PreferenceDialog(MainApplication.getMainFrame());
-        if (tab != null) {
-            p.selectPreferencesTabByClass(tab);
-        } else if (subTab != null) {
-            p.selectSubPreferencesTabByClass(subTab);
-        } else {
-            p.selectPreviouslySelectedPreferences();
-        }
+        SwingUtilities.invokeLater(() -> {
+            if (tab != null) {
+                p.selectPreferencesTabByClass(tab);
+            } else if (subTab != null) {
+                p.selectSubPreferencesTabByClass(subTab);
+            } else {
+                p.selectPreviouslySelectedPreferences();
+            }
+        });
         p.setVisible(true);
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -582 +582 @@
                 pref.addActionListener(e -> {
                     final PreferenceDialog p = new PreferenceDialog(MainApplication.getMainFrame());
-                    if (TabPreferenceSetting.class.isAssignableFrom(preferenceClass)) {
-                        p.selectPreferencesTabByClass((Class<? extends TabPreferenceSetting>) preferenceClass);
-                    } else if (SubPreferenceSetting.class.isAssignableFrom(preferenceClass)) {
-                        p.selectSubPreferencesTabByClass((Class<? extends SubPreferenceSetting>) preferenceClass);
-                    }
+                    SwingUtilities.invokeLater(() -> {
+                        if (TabPreferenceSetting.class.isAssignableFrom(preferenceClass)) {
+                            p.selectPreferencesTabByClass((Class<? extends TabPreferenceSetting>) preferenceClass);
+                        } else if (SubPreferenceSetting.class.isAssignableFrom(preferenceClass)) {
+                            p.selectSubPreferencesTabByClass((Class<? extends SubPreferenceSetting>) preferenceClass);
+                        }
+                    });
                     p.setVisible(true);
                 });

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -528 +528 @@
     private void addGUITabs(boolean clear) {
         boolean expert = ExpertToggleAction.isExpert();
-        Component sel = getSelectedComponent();
         if (clear) {
             removeAll();
@@ -561 +560 @@
             });
         }
+        setSelectedIndex(-1);
+    }
+
+    @Override
+    public void expertChanged(boolean isExpert) {
+        Component sel = getSelectedComponent();
+        addGUITabs(true);
         int index = -1;
         if (sel != null) {
             index = indexOfComponent(sel);
         }
-        setSelectedIndex(index);
-    }
-
-    @Override
-    public void expertChanged(boolean isExpert) {
-        addGUITabs(true);
+        setSelectedIndex(Math.max(index, 0));
     }
 

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -52 +52 @@
 import javax.swing.ListSelectionModel;
 import javax.swing.MenuElement;
+import javax.swing.SwingUtilities;
 import javax.swing.TransferHandler;
 import javax.swing.event.PopupMenuEvent;
@@ -513 +514 @@
             public void actionPerformed(ActionEvent e) {
                 final PreferenceDialog p = new PreferenceDialog(MainApplication.getMainFrame());
-                p.selectPreferencesTabByName("toolbar");
+                SwingUtilities.invokeLater(() -> p.selectPreferencesTabByName("toolbar"));
                 p.setVisible(true);
             }
@@ -523 +524 @@
                 final PreferenceDialog p = new PreferenceDialog(MainApplication.getMainFrame());
                 p.getTabbedPane().getShortcutPreference().setDefaultFilter(act.getDisplayName());
-                p.selectPreferencesTabByName("shortcuts");
+                SwingUtilities.invokeLater(() -> p.selectPreferencesTabByName("shortcuts"));
                 p.setVisible(true);
                 // refresh toolbar to try using changed shortcuts without restart