Changeset 17189 in josm

Timestamp:

2020-10-13T20:40:32+02:00 (4 years ago)

Author:

simon04

Message:

see #15102 - see #16637 - get rid of real HTTP calls to https://josm.openstreetmap.de/josmticket in unit tests, mock them

File:

• trunk/test/unit/org/openstreetmap/josm/tools/bugreport/BugReportSenderTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/tools/bugreport/BugReportSenderTest.java

@@ -2 +2 @@
 package org.openstreetmap.josm.tools.bugreport;
 
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.containing;
+import static com.github.tomakehurst.wiremock.client.WireMock.exactly;
+import static com.github.tomakehurst.wiremock.client.WireMock.post;
+import static com.github.tomakehurst.wiremock.client.WireMock.postRequestedFor;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
+import static com.github.tomakehurst.wiremock.client.WireMock.verify;
+import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.options;
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 
+import java.net.URI;
+import java.util.List;
+
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
 import org.openstreetmap.josm.JOSMFixture;
 import org.openstreetmap.josm.actions.ShowStatusReportAction;
+import org.openstreetmap.josm.spi.preferences.Config;
+import org.openstreetmap.josm.testutils.mockers.OpenBrowserMocker;
+
+import com.github.tomakehurst.wiremock.junit.WireMockRule;
 
 /**
@@ -25 +42 @@
 
     /**
+     * HTTP mock.
+     */
+    @Rule
+    public WireMockRule wireMockRule = new WireMockRule(options().dynamicPort());
+
+    /**
      * Unit test for {@link BugReportSender#BugReportSender}.
      * @throws InterruptedException if the thread is interrupted
@@ -30 +53 @@
     @Test
     public void testBugReportSender() throws InterruptedException {
+        Config.getPref().put("josm.url", wireMockRule.baseUrl());
+        wireMockRule.stubFor(post(urlEqualTo("/josmticket"))
+                .willReturn(aResponse()
+                        .withStatus(200)
+                        .withHeader("Content-Type", "text/xml")
+                        .withBody("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
+                                "<josmticket status=\"ok\">\n" +
+                                "  <preparedid>6bccff5c0417217bfbbe5fff</preparedid>\n" +
+                                "</josmticket>\n")));
+        new OpenBrowserMocker();
+
         BugReportSender sender = BugReportSender.reportBug(ShowStatusReportAction.getReportHeader());
         assertNotNull(sender);
@@ -37 +71 @@
             }
         }
+
         assertFalse(sender.isAlive());
         assertNull(sender.getErrorMessage(), sender.getErrorMessage());
+        verify(exactly(1), postRequestedFor(urlEqualTo("/josmticket")).withRequestBody(containing("pdata=")));
+
+        List<URI> calledURIs = OpenBrowserMocker.getCalledURIs();
+        assertEquals(1, calledURIs.size());
+        assertEquals(wireMockRule.baseUrl() + "/josmticket?pdata_stored=6bccff5c0417217bfbbe5fff", calledURIs.get(0).toString());
     }
 }