Changeset 17146 in josm

Timestamp:

2020-10-10T19:05:40+02:00 (4 years ago)

Author:

simon04

Message:

see #19902 - Advanced preferences: use FlowLayout for buttons, add tooltip

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/advanced/AdvancedPreference.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/AdvancedPreference.java

@@ -7 +7 @@
 import java.awt.Dimension;
 import java.awt.GridBagLayout;
+import java.awt.GridLayout;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
@@ -24 +25 @@
 
 import javax.swing.AbstractAction;
-import javax.swing.Box;
 import javax.swing.JButton;
 import javax.swing.JFileChooser;
@@ -202 +202 @@
         scroll.setPreferredSize(new Dimension(400, 200));
 
+        JPanel buttonPanel = new JPanel(new GridLayout(1, 6));
         JButton add = new JButton(tr("Add"), ImageProvider.get("dialogs/add", ImageProvider.ImageSizes.SMALLICON));
-        p.add(Box.createHorizontalGlue(), GBC.std().fill(GBC.HORIZONTAL));
-        p.add(add, GBC.std().insets(0, 5, 0, 0));
+        buttonPanel.add(add);
+        add.setToolTipText(add.getText());
         add.addActionListener(e -> {
             PrefEntry pe = table.addPreference(gui);
@@ -215 +216 @@
 
         JButton edit = new JButton(tr("Edit"), ImageProvider.get("dialogs/edit", ImageProvider.ImageSizes.SMALLICON));
-        p.add(edit, GBC.std().insets(5, 5, 5, 0));
+        buttonPanel.add(edit);
+        edit.setToolTipText(edit.getText());
         edit.addActionListener(e -> {
             if (table.editPreference(gui))
@@ -223 +225 @@
 
         JButton reset = new JButton(tr("Reset"), ImageProvider.get("undo", ImageProvider.ImageSizes.SMALLICON));
-        p.add(reset, GBC.std().insets(0, 5, 0, 0));
+        buttonPanel.add(reset);
+        reset.setToolTipText(reset.getText());
         reset.addActionListener(e -> table.resetPreferences(gui));
         table.getSelectionModel().addListSelectionListener(event -> reset.setEnabled(table.getSelectedRowCount() > 0));
 
         JButton read = new JButton(tr("Read from file"), ImageProvider.get("open", ImageProvider.ImageSizes.SMALLICON));
-        p.add(read, GBC.std().insets(5, 5, 0, 0));
+        buttonPanel.add(read);
+        read.setToolTipText(read.getText());
         read.addActionListener(e -> readPreferencesFromXML());
 
         JButton export = new JButton(tr("Export selected items"), ImageProvider.get("save", ImageProvider.ImageSizes.SMALLICON));
-        p.add(export, GBC.std().insets(5, 5, 0, 0));
+        buttonPanel.add(export);
+        export.setToolTipText(export.getText());
         export.addActionListener(e -> exportSelectedToXML());
 
         final JButton more = new JButton(tr("More..."));
-        p.add(more, GBC.std().insets(5, 5, 0, 0));
+        buttonPanel.add(more);
+        more.setToolTipText(more.getText());
         more.addActionListener(new ActionListener() {
             private final JPopupMenu menu = buildPopupMenu();
@@ -246 +252 @@
             }
         });
+        p.add(buttonPanel, GBC.eol());
     }