Changeset 17050 in josm for trunk/resources

Timestamp:

2020-09-22T17:40:37+02:00 (4 years ago)

Author:

Klumbumbus

Message:

fix #19572 - Add more warnings about lanes and surface on suspicious objects (based on patch by Famlam)

File:

• trunk/resources/data/validator/combinations.mapcss (modified) (5 diffs)

trunk/resources/data/validator/combinations.mapcss

@@ -9 +9 @@
 /* {0.key} without {1.key} (warning level) */
 way[junction                   ][!highway][junction!=yes][!area:highway],
-way[lanes                      ][!highway][leisure!=track][leisure!=swimming_pool],
 way[living_street              ][!highway],
 way[maintenance                ][!highway],
@@ -74 +73 @@
   throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
   group: tr("missing tag");
-  assertMatch: "way lanes=42";
-  assertNoMatch: "way lanes=42 highway=unclassified";
   assertMatch: "node source:addr:postcode=postman";
 }
@@ -338 +335 @@
 }
 
-/* only {0.key}, see #11104 #12422 #14950 */
+/* only {0.key}, #11104, #12422, #14950, #19572 */
+*[lanes][eval(number_of_tags()) = 1],
+*[surface][eval(number_of_tags()) = 1],
 *[access][eval(number_of_tags()) = 1],
 *[area][eval(number_of_tags()) = 1]!.area_yes_autofix,
@@ -345 +344 @@
 *[lit][eval(number_of_tags()) = 1] {
   throwWarning: tr("incomplete object: only {0}", "{0.key}");
+  set only_one_tag;
   group: tr("missing tag");
 }
@@ -406 +406 @@
 }
 
-/* {0} on suspicious object, #17255, #19650 */
+/* {0} on suspicious object, #17255, #19650, #19572 */
+node[lanes ][!barrier][!ford][highway!=mini_roundabout][!junction][leisure!~/^(bowling_alley|slipway|swimming_pool|track)$/][!traffic_calming]!.only_one_tag,
+way[lanes  ][!barrier][!ford][!highway                ][!junction][leisure!~/^(bowling_alley|slipway|swimming_pool|track)$/][!traffic_calming]!.only_one_tag,
 *[tunnel   ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=tunnel],
 *[bridge   ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=bridge][building!=bridge],