Changeset 16966 in josm for trunk

Timestamp:

2020-08-29T16:38:58+02:00 (4 years ago)

Author:

simon04

Message:

fix #19732 - Preferences: open previously selected preference tab

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/PreferencesAction.java (modified) (1 diff)
• gui/preferences/DefaultTabPreferenceSetting.java (modified) (1 diff)
• gui/preferences/PreferenceDialog.java (modified) (4 diffs)
• gui/preferences/PreferenceTabbedPane.java (modified) (2 diffs)
• gui/preferences/TabPreferenceSetting.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/PreferencesAction.java

@@ -109 +109 @@
         } else if (subTab != null) {
             p.selectSubPreferencesTabByClass(subTab);
+        } else {
+            p.selectPreviouslySelectedPreferences();
         }
         p.setVisible(true);

trunk/src/org/openstreetmap/josm/gui/preferences/DefaultTabPreferenceSetting.java

@@ -142 +142 @@
 
     @Override
+    public Class<? extends SubPreferenceSetting> getSelectedSubTab() {
+        if (tabpane == null || subSettingMap == null) {
+            return null;
+        }
+        final Component selected = tabpane.getSelectedComponent();
+        return subSettingMap.entrySet().stream()
+                .filter(e -> e.getValue() == selected)
+                .map(e -> e.getKey().getClass())
+                .findFirst().orElse(null);
+    }
+
+    @Override
     public String getHelpContext() {
         return HelpUtil.ht("/Action/Preferences");

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceDialog.java

@@ -31 +31 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.InputMapUtils;
+import org.openstreetmap.josm.tools.Pair;
 
 /**
@@ -45 +46 @@
     private final WindowEventHandler windowEventHandler = new WindowEventHandler();
     private boolean canceled;
+    private static Pair<Class<? extends TabPreferenceSetting>, Class<? extends SubPreferenceSetting>> previouslySelected;
 
     /**
@@ -145 +147 @@
 
     /**
+     * Select preferences tab that was selected previously.
+     */
+    public void selectPreviouslySelectedPreferences() {
+        if (previouslySelected != null && previouslySelected.b != null) {
+            tpPreferences.selectSubTabByPref(previouslySelected.b);
+        } else if (previouslySelected != null && previouslySelected.a != null) {
+            tpPreferences.selectTabByPref(previouslySelected.a);
+        }
+    }
+
+    /**
      * Select preferences tab by name.
      * @param name preferences tab name (icon)
@@ -215 +228 @@
     @Override
     public void dispose() {
+        previouslySelected = tpPreferences.getSelectedTab();
         removeWindowListener(windowEventHandler);
         super.dispose();

trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -71 +71 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.Pair;
 import org.openstreetmap.josm.tools.Utils;
 import org.openstreetmap.josm.tools.bugreport.BugReportExceptionHandler;
@@ -354 +355 @@
             Logging.trace(ignore);
             return false;
+        }
+    }
+
+    /**
+     * Returns the currently selected preference and sub preference setting
+     * @return the currently selected preference and sub preference setting
+     */
+    public Pair<Class<? extends TabPreferenceSetting>, Class<? extends SubPreferenceSetting>> getSelectedTab() {
+        final Component selected = getSelectedComponent();
+        if (selected instanceof PreferenceTab) {
+            final TabPreferenceSetting setting = ((PreferenceTab) selected).getTabPreferenceSetting();
+            return Pair.create(setting.getClass(), setting.getSelectedSubTab());
+        } else {
+            return null;
         }
     }

trunk/src/org/openstreetmap/josm/gui/preferences/TabPreferenceSetting.java

@@ -72 +72 @@
 
     /**
+     * Returns the currently selected sub preference setting
+     * @return the currently selected sub preference setting
+     */
+    Class<? extends SubPreferenceSetting> getSelectedSubTab();
+
+    /**
      * Selects the specified sub preference settings, if applicable. Not all Tab preference settings need to implement this.
      * @param subPref The sub preference settings to be selected.