Changeset 16913 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2020-08-23T15:31:04+02:00 (4 years ago)

Author:

simon04

Message:

fix #19698 - Refactoring: make private fields final

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• data/cache/HostLimitQueueTest.java (modified) (1 diff)
• data/cache/JCSCachedTileLoaderJobTest.java (modified) (1 diff)
• data/imagery/TMSCachedTileLoaderJobTest.java (modified) (1 diff)
• data/imagery/WMTSTileSourceTest.java (modified) (1 diff)
• data/osm/OsmPrimitiveTest.java (modified) (1 diff)
• data/projection/ProjectionTest.java (modified) (1 diff)
• data/projection/SwissGridTest.java (modified) (1 diff)
• gui/conflict/pair/nodes/NodeListMergeModelTest.java (modified) (1 diff)
• gui/dialogs/relation/sort/WayConnectionTypeCalculatorTest.java (modified) (1 diff)
• plugins/PluginHandlerTestIT.java (modified) (1 diff)
• testutils/JOSMTestRules.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/data/cache/HostLimitQueueTest.java

@@ -37 +37 @@
      */
     static class Task extends JCSCachedTileLoaderJob<String, CacheEntry> {
-        private URL url;
-        private AtomicInteger counter;
+        private final URL url;
+        private final AtomicInteger counter;
 
         Task(ICacheAccess<String, CacheEntry> cache, URL url, AtomicInteger counter) {

trunk/test/unit/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJobTest.java

@@ -44 +44 @@
 
     private static class TestCachedTileLoaderJob extends JCSCachedTileLoaderJob<String, CacheEntry> {
-        private String url;
-        private String key;
+        private final String url;
+        private final String key;
 
         TestCachedTileLoaderJob(String url, String key) {

trunk/test/unit/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJobTest.java

@@ -66 +66 @@
 
     private static class TestCachedTileLoaderJob extends TMSCachedTileLoaderJob {
-        private String url;
-        private String key;
+        private final String url;
+        private final String key;
 
         TestCachedTileLoaderJob(TileLoaderListener listener, Tile tile, String key) throws IOException {

trunk/test/unit/org/openstreetmap/josm/data/imagery/WMTSTileSourceTest.java

@@ -53 +53 @@
     public WireMockRule tileServer = new WireMockRule(WireMockConfiguration.options().dynamicPort());
 
-    private ImageryInfo testImageryTMS = new ImageryInfo("test imagery", "http://localhost", "tms", null, null);
-    private ImageryInfo testImageryPSEUDO_MERCATOR = getImagery(TestUtils.getTestDataRoot() + "wmts/getcapabilities-pseudo-mercator.xml");
-    private ImageryInfo testImageryTOPO_PL = getImagery(TestUtils.getTestDataRoot() + "wmts/getcapabilities-TOPO.xml");
-    private ImageryInfo testImageryORTO_PL = getImagery(TestUtils.getTestDataRoot() + "wmts/getcapabilities-ORTO.xml");
-    private ImageryInfo testImageryWIEN = getImagery(TestUtils.getTestDataRoot() + "wmts/getCapabilities-wien.xml");
-    private ImageryInfo testImageryWALLONIE = getImagery(TestUtils.getTestDataRoot() + "wmts/WMTSCapabilities-Wallonie.xml");
-    private ImageryInfo testImageryOntario = getImagery(TestUtils.getTestDataRoot() + "wmts/WMTSCapabilities-Ontario.xml");
-    private ImageryInfo testImageryGeoAdminCh = getImagery(TestUtils.getTestDataRoot() + "wmts/WMTSCapabilities-GeoAdminCh.xml");
-    private ImageryInfo testImagery12168 = getImagery(TestUtils.getTestDataRoot() + "wmts/bug12168-WMTSCapabilities.xml");
-    private ImageryInfo testLotsOfLayers = getImagery(TestUtils.getTestDataRoot() + "wmts/getCapabilities-lots-of-layers.xml");
-    private ImageryInfo testDuplicateTags = getImagery(TestUtils.getTestDataRoot() + "wmts/bug12573-wmts-identifier.xml");
-    private ImageryInfo testMissingStyleIdentifer = getImagery(TestUtils.getTestDataRoot() + "wmts/bug12573-wmts-missing-style-identifier.xml");
-    private ImageryInfo testMultipleTileMatrixForLayer = getImagery(TestUtils.getTestDataRoot() +
+    private final ImageryInfo testImageryTMS = new ImageryInfo("test imagery", "http://localhost", "tms", null, null);
+    private final ImageryInfo testImageryPSEUDO_MERCATOR = getImagery(TestUtils.getTestDataRoot() + "wmts/getcapabilities-pseudo-mercator.xml");
+    private final ImageryInfo testImageryTOPO_PL = getImagery(TestUtils.getTestDataRoot() + "wmts/getcapabilities-TOPO.xml");
+    private final ImageryInfo testImageryORTO_PL = getImagery(TestUtils.getTestDataRoot() + "wmts/getcapabilities-ORTO.xml");
+    private final ImageryInfo testImageryWIEN = getImagery(TestUtils.getTestDataRoot() + "wmts/getCapabilities-wien.xml");
+    private final ImageryInfo testImageryWALLONIE = getImagery(TestUtils.getTestDataRoot() + "wmts/WMTSCapabilities-Wallonie.xml");
+    private final ImageryInfo testImageryOntario = getImagery(TestUtils.getTestDataRoot() + "wmts/WMTSCapabilities-Ontario.xml");
+    private final ImageryInfo testImageryGeoAdminCh = getImagery(TestUtils.getTestDataRoot() + "wmts/WMTSCapabilities-GeoAdminCh.xml");
+    private final ImageryInfo testImagery12168 = getImagery(TestUtils.getTestDataRoot() + "wmts/bug12168-WMTSCapabilities.xml");
+    private final ImageryInfo testLotsOfLayers = getImagery(TestUtils.getTestDataRoot() + "wmts/getCapabilities-lots-of-layers.xml");
+    private final ImageryInfo testDuplicateTags = getImagery(TestUtils.getTestDataRoot() + "wmts/bug12573-wmts-identifier.xml");
+    private final ImageryInfo testMissingStyleIdentifer = getImagery(TestUtils.getTestDataRoot() + "wmts/bug12573-wmts-missing-style-identifier.xml");
+    private final ImageryInfo testMultipleTileMatrixForLayer = getImagery(TestUtils.getTestDataRoot() +
             "wmts/bug13975-multiple-tile-matrices-for-one-layer-projection.xml");
-    private ImageryInfo testImageryGisKtnGvAt = getImagery(TestUtils.getTestDataRoot() + "wmts/gis.ktn.gv.at.xml");
+    private final ImageryInfo testImageryGisKtnGvAt = getImagery(TestUtils.getTestDataRoot() + "wmts/gis.ktn.gv.at.xml");
 
     private static ImageryInfo getImagery(String path) {

trunk/test/unit/org/openstreetmap/josm/data/osm/OsmPrimitiveTest.java

@@ -33 +33 @@
     }
 
-    private DataSet dataSet = new DataSet();
+    private final DataSet dataSet = new DataSet();
 
     /**

trunk/test/unit/org/openstreetmap/josm/data/projection/ProjectionTest.java

@@ -21 +21 @@
 public class ProjectionTest {
 
-    private static Random rand = new SecureRandom();
+    private static final Random rand = new SecureRandom();
 
     boolean error;

trunk/test/unit/org/openstreetmap/josm/data/projection/SwissGridTest.java

@@ -19 +19 @@
 public class SwissGridTest {
     private static final String SWISS_EPSG_CODE = "EPSG:21781";
-    private boolean debug = false;
+    private final boolean debug = false;
 
     /**

trunk/test/unit/org/openstreetmap/josm/gui/conflict/pair/nodes/NodeListMergeModelTest.java

@@ -36 +36 @@
 public class NodeListMergeModelTest {
 
-    private DatasetFactory my = new DatasetFactory();
-    private DatasetFactory their = new DatasetFactory();
+    private final DatasetFactory my = new DatasetFactory();
+    private final DatasetFactory their = new DatasetFactory();
 
     /**

trunk/test/unit/org/openstreetmap/josm/gui/dialogs/relation/sort/WayConnectionTypeCalculatorTest.java

@@ -33 +33 @@
 public class WayConnectionTypeCalculatorTest {
 
-    private RelationSorter sorter = new RelationSorter();
-    private WayConnectionTypeCalculator wayConnectionTypeCalculator = new WayConnectionTypeCalculator();
+    private final RelationSorter sorter = new RelationSorter();
+    private final WayConnectionTypeCalculator wayConnectionTypeCalculator = new WayConnectionTypeCalculator();
     private DataSet testDataset;
 

trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java

@@ -46 +46 @@
 public class PluginHandlerTestIT {
 
-    private static List<String> errorsToIgnore = new ArrayList<>();
+    private static final List<String> errorsToIgnore = new ArrayList<>();
     /**
      * Setup test.

trunk/test/unit/org/openstreetmap/josm/testutils/JOSMTestRules.java

@@ -726 +726 @@
     private static class FailOnTimeoutStatement extends Statement {
 
-        private int timeout;
-        private Statement original;
+        private final int timeout;
+        private final Statement original;
 
         FailOnTimeoutStatement(Statement original, int timeout) {
@@ -760 +760 @@
     private static final class TimeoutThread extends Thread {
         public boolean isDone;
-        private Statement original;
+        private final Statement original;
         private Throwable exceptionCaught;