Changeset 16626 in josm for trunk/src

Timestamp:

2020-06-14T14:55:23+02:00 (4 years ago)

Author:

simon04

Message:

see #19334 - ​https://errorprone.info/bugpattern/ImmutableEnumChecker

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/mapmode/DeleteAction.java (modified) (1 diff)
• actions/mapmode/SelectAction.java (modified) (1 diff)
• data/osm/OsmPrimitiveType.java (modified) (1 diff)
• data/osm/visitor/paint/PaintColors.java (modified) (1 diff)
• data/projection/CustomProjection.java (modified) (1 diff)
• data/validation/Severity.java (modified) (1 diff)
• gui/MenuScroller.java (modified) (1 diff)
• gui/conflict/ConflictColors.java (modified) (1 diff)
• gui/conflict/pair/ComparePairType.java (modified) (5 diffs)
• gui/dialogs/ValidatorListManagementDialog.java (modified) (1 diff)
• gui/history/TwoColumnDiff.java (modified) (1 diff)
• gui/mappaint/mapcss/ConditionFactory.java (modified) (1 diff)
• tools/OptionParser.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/mapmode/DeleteAction.java

@@ -75 +75 @@
         way_with_nodes(/* ICON(cursor/modifier/) */ "delete_way_node_only");
 
+        @SuppressWarnings("ImmutableEnumChecker")
         private final Cursor c;
 

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -109 +109 @@
         move(Cursor.MOVE_CURSOR);
 
+        @SuppressWarnings("ImmutableEnumChecker")
         private final Cursor c;
         SelectActionCursor(String main, String sub) {

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitiveType.java

@@ -32 +32 @@
     private final Class<? extends OsmPrimitive> osmClass;
     private final Class<? extends PrimitiveData> dataClass;
+    @SuppressWarnings("ImmutableEnumChecker")
     private final UniqueIdGenerator idGenerator;
 

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/PaintColors.java

@@ -79 +79 @@
     AREA_TEXT(marktr("areatext"), Color.LIGHT_GRAY);
 
+    @SuppressWarnings("ImmutableEnumChecker")
     private final NamedColorProperty baseProperty;
+    @SuppressWarnings("ImmutableEnumChecker")
     private final CachingProperty<Color> property;
 

trunk/src/org/openstreetmap/josm/data/projection/CustomProjection.java

@@ -185 +185 @@
         SOUTH(LatLon.SOUTH_POLE);
 
+        @SuppressWarnings("ImmutableEnumChecker")
         private final LatLon latlon;
 

trunk/src/org/openstreetmap/josm/data/validation/Severity.java

@@ -31 +31 @@
 
     /** Associated color */
+    @SuppressWarnings("ImmutableEnumChecker") // see https://github.com/google/error-prone/pull/1682
     private final Color color;
 

trunk/src/org/openstreetmap/josm/gui/MenuScroller.java

@@ -422 +422 @@
         DOWN(1, 9, 1);
         private static final int[] XPOINTS = {1, 5, 9};
+        @SuppressWarnings("ImmutableEnumChecker")
         private final int[] yPoints;
 

trunk/src/org/openstreetmap/josm/gui/conflict/ConflictColors.java

@@ -82 +82 @@
     FGCOLOR_MEMBER_REMOVE(marktr("Conflict foreground: remove member"), Color.black);
 
+    @SuppressWarnings("ImmutableEnumChecker")
     private final NamedColorProperty property;
 

trunk/src/org/openstreetmap/josm/gui/conflict/pair/ComparePairType.java

@@ -5 +5 @@
 import static org.openstreetmap.josm.gui.conflict.pair.ListRole.THEIR_ENTRIES;
 import static org.openstreetmap.josm.tools.I18n.tr;
-
-import java.util.Arrays;
-
-import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -33 +29 @@
     /** the localized display name */
     private final String displayName;
-    private final ListRole[] participatingRoles;
+    private final ListRole participatingRole1;
+    private final ListRole participatingRole2;
 
-    ComparePairType(String displayName, ListRole... participatingRoles) {
+    ComparePairType(String displayName, ListRole participatingRole1, ListRole participatingRole2) {
         this.displayName = displayName;
-        this.participatingRoles = Utils.copyArray(participatingRoles);
+        this.participatingRole1 = participatingRole1;
+        this.participatingRole2 = participatingRole2;
     }
 
@@ -56 +54 @@
      */
     public boolean isParticipatingIn(ListRole role) {
-        return Arrays.stream(participatingRoles).anyMatch(r -> r == role);
+        return participatingRole1 == role || participatingRole2 == role;
     }
 
@@ -65 +63 @@
      */
     public ListRole[] getParticipatingRoles() {
-        return Utils.copyArray(participatingRoles);
+        return new ListRole[]{participatingRole1, participatingRole2};
     }
 
@@ -78 +76 @@
         if (!isParticipatingIn(role))
             throw new IllegalStateException(tr("Role {0} is not participating in compare pair {1}.", role.toString(), this.toString()));
-        if (participatingRoles[0] == role)
-            return participatingRoles[1];
-        else
-            return participatingRoles[0];
+        return participatingRole1 == role ? participatingRole2 : participatingRole1;
     }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorListManagementDialog.java

@@ -49 +49 @@
         CANCEL(1, tr("Cancel"), new ImageProvider("cancel"));
 
-        private int index;
-        private String name;
-        private ImageIcon icon;
+        private final int index;
+        private final String name;
+        @SuppressWarnings("ImmutableEnumChecker")
+        private final ImageIcon icon;
 
         BUTTONS(int index, String name, ImageProvider image) {

trunk/src/org/openstreetmap/josm/gui/history/TwoColumnDiff.java

@@ -39 +39 @@
             EMPTY(new Color(234, 234, 234));
 
+            @SuppressWarnings("ImmutableEnumChecker") // see https://github.com/google/error-prone/pull/1682
             private final Color color;
             DiffItemType(Color color) {

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ConditionFactory.java

@@ -182 +182 @@
         static final Set<Op> NEGATED_OPS = EnumSet.of(NEQ, NREGEX);
 
+        @SuppressWarnings("ImmutableEnumChecker")
         private final BiPredicate<String, String> function;
 

trunk/src/org/openstreetmap/josm/tools/OptionParser.java

@@ -251 +251 @@
         MULTIPLE(0, Integer.MAX_VALUE);
 
-        private int min;
-        private int max;
+        private final int min;
+        private final int max;
 
         OptionCount(int min, int max) {