Changeset 16590 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2020-06-10T08:04:42+02:00 (4 years ago)

Author:

simon04

Message:

fix #19197 - MapCSS JOSM_pref: check if a pref could be converted to a color instead of a string (patch by taylor.smock, modified)

File:

• trunk/test/unit/org/openstreetmap/josm/gui/mappaint/mapcss/FunctionsTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/mappaint/mapcss/FunctionsTest.java

@@ -6 +6 @@
 import static org.openstreetmap.josm.data.osm.OsmPrimitiveType.NODE;
 
+import java.util.Collections;
+
 import org.junit.Rule;
 import org.junit.Test;
@@ -12 +14 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
 import org.openstreetmap.josm.data.osm.User;
+import org.openstreetmap.josm.data.preferences.NamedColorProperty;
 import org.openstreetmap.josm.gui.mappaint.Environment;
 import org.openstreetmap.josm.gui.util.GuiHelper;
@@ -113 +116 @@
     public void testPref() {
         String key = "Functions.JOSM_pref";
+        Config.getPref().put(key, null);
         assertEquals("foobar", Functions.JOSM_pref(null, key, "foobar"));
         Config.getPref().put(key, "baz");
@@ -124 +128 @@
         });
         assertEquals("foobar", Functions.JOSM_pref(null, key, "foobar"));
+        Config.getPref().put(key, null);
     }
+
+    /**
+     * Unit test of {@link Functions#JOSM_pref}, color handling
+     */
+    @Test
+    public void testPrefColor() {
+        String key = "Functions.JOSM_pref";
+        String colorKey = NamedColorProperty.NAMED_COLOR_PREFIX + NamedColorProperty.COLOR_CATEGORY_MAPPAINT + ".unknown." + key;
+        Config.getPref().put(colorKey, null);
+        assertEquals("#000000", Functions.JOSM_pref(null, key, "#000000"));
+        Config.getPref().putList(colorKey, Collections.singletonList("#00FF00"));
+        GuiHelper.runInEDTAndWait(() -> {
+            // await org.openstreetmap.josm.gui.mappaint.ElemStyles.clearCached
+        });
+        assertEquals("#00FF00", Functions.JOSM_pref(null, key, "#000000"));
+        Config.getPref().put(colorKey, null);
+        GuiHelper.runInEDTAndWait(() -> {
+            // await org.openstreetmap.josm.gui.mappaint.ElemStyles.clearCached
+        });
+        assertEquals("#000000", Functions.JOSM_pref(null, key, "#000000"));
+        Config.getPref().put(colorKey, null);
+    }
+
 }