Changeset 16555 in josm

Timestamp:

2020-06-07T15:23:42+02:00 (5 years ago)

Author:

Don-vip

Message:

see #19334 - avoid ConcurrentModificationException while iterating over maps

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/validation/tests/DuplicateNode.java (modified) (1 diff)
• gui/preferences/imagery/ImageryProvidersPanel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/DuplicateNode.java

@@ -187 +187 @@
                                 Way w = (Way) sp;
                                 Map<String, String> keys = w.getKeys();
-                                for (String type: typeMap.keySet()) {
-                                    if (keys.containsKey(type)) {
-                                        typeMap.put(type, Boolean.TRUE);
+                                for (Iterator<Entry<String, Boolean>> itt = typeMap.entrySet().iterator(); itt.hasNext();) {
+                                    Entry<String, Boolean> e = itt.next();
+                                    if (keys.containsKey(e.getKey())) {
+                                        e.setValue(Boolean.TRUE);
                                         typed = true;
                                     }

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryProvidersPanel.java

@@ -19 +19 @@
 import java.util.HashMap;
 import java.util.HashSet;
+import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Objects;
 import java.util.Optional;
@@ -409 +411 @@
 
         private <T> void doCleanupResidualBounds(Map<Integer, T> map, Consumer<T> removalEffect) {
-            for (Integer i : map.keySet()) {
-                int viewIndex = defaultTable.convertRowIndexToView(i);
+            for (Iterator<Entry<Integer, T>> it = map.entrySet().iterator(); it.hasNext();) {
+                Entry<Integer, T> e = it.next();
+                int viewIndex = defaultTable.convertRowIndexToView(e.getKey());
                 if (!defaultTable.getSelectionModel().isSelectedIndex(viewIndex)) {
-                    removalEffect.accept(map.remove(i));
+                    it.remove();
+                    removalEffect.accept(e.getValue());
                 }
             }