Changeset 16395 in josm for trunk/src/org/openstreetmap

Timestamp:

2020-05-10T08:12:49+02:00 (5 years ago)

Author:

GerdP

Message:

fix #18680: Listener was not registered before: LayerChangeAdapter

Location:

trunk/src/org/openstreetmap/josm/gui/history

Files:

• HistoryBrowser.java (modified) (2 diffs)
• VersionTable.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowser.java

@@ -6 +6 @@
 import java.awt.BorderLayout;
 import java.awt.Dimension;
+import java.util.Arrays;
 
 import javax.swing.JPanel;
@@ -152 +153 @@
     @Override
     public void destroy() {
-        model.unlinkAsListener();
-        for (Destroyable component : new Destroyable[] {
-                tagInfoViewer, nodeListViewer, relationMemberListViewer, coordinateInfoViewer}) {
-            component.destroy();
+        if (model != null) {
+            model.unlinkAsListener();
+            model = null;
         }
+        Arrays.asList(tagInfoViewer, nodeListViewer, relationMemberListViewer, coordinateInfoViewer).stream()
+                .filter(Destroyable.class::isInstance).forEach(Destroyable::destroy);
+        tagInfoViewer = null;
+        nodeListViewer = null;
+        relationMemberListViewer = null;
+        coordinateInfoViewer = null;
     }
 }

trunk/src/org/openstreetmap/josm/gui/history/VersionTable.java

@@ -255 +255 @@
         @Override
         public void destroy() {
-            if (changesetInfoAction != null)
+            if (changesetInfoAction != null) {
                 changesetInfoAction.destroy();
-            if (userInfoAction != null)
+                changesetInfoAction = null;
+            }
+            if (userInfoAction != null) {
                 userInfoAction.destroy();
+                userInfoAction = null;
+            }
         }
     }