Changeset 16335 in josm for trunk/src

Timestamp:

2020-04-18T10:41:28+02:00 (5 years ago)

Author:

simon04

Message:

fix #19113 - Use JCS class instead of CompositeCacheManager

File:

• trunk/src/org/openstreetmap/josm/data/cache/JCSCacheManager.java (modified) (9 diffs)

trunk/src/org/openstreetmap/josm/data/cache/JCSCacheManager.java

@@ -15 +15 @@
 import java.util.logging.SimpleFormatter;
 
+import org.apache.commons.jcs.JCS;
 import org.apache.commons.jcs.access.CacheAccess;
 import org.apache.commons.jcs.auxiliary.AuxiliaryCache;
@@ -26 +27 @@
 import org.apache.commons.jcs.engine.behavior.ICompositeCacheAttributes.DiskUsagePattern;
 import org.apache.commons.jcs.engine.control.CompositeCache;
-import org.apache.commons.jcs.engine.control.CompositeCacheManager;
 import org.apache.commons.jcs.utils.serialization.StandardSerializer;
 import org.openstreetmap.josm.data.preferences.BooleanProperty;
@@ -42 +42 @@
  */
 public final class JCSCacheManager {
-    private static volatile CompositeCacheManager cacheManager;
     private static final long maxObjectTTL = -1;
     private static final String PREFERENCE_PREFIX = "jcs.cache";
@@ -112 +111 @@
     }
 
-    @SuppressWarnings("resource")
-    private static void initialize() {
+    static {
         File cacheDir = new File(Config.getDirs().getCacheDirectory(true), "jcs");
 
@@ -154 +152 @@
         // CHECKSTYLE.ON: SingleSpaceSeparator
         try {
-            CompositeCacheManager cm = CompositeCacheManager.getUnconfiguredInstance();
-            cm.configure(props);
-            cacheManager = cm;
+            JCS.setConfigProperties(props);
         } catch (SecurityException e) {
             Logging.log(Logging.LEVEL_WARN, "Unable to initialize JCS", e);
@@ -183 +179 @@
      * @return cache access object
      */
+    @SuppressWarnings("unchecked")
     public static <K, V> CacheAccess<K, V> getCache(String cacheName, int maxMemoryObjects, int maxDiskObjects, String cachePath) {
-        if (cacheManager != null)
-            return getCacheInner(cacheName, maxMemoryObjects, maxDiskObjects, cachePath);
-
-        synchronized (JCSCacheManager.class) {
-            if (cacheManager == null)
-                initialize();
-            return cacheManager != null ? getCacheInner(cacheName, maxMemoryObjects, maxDiskObjects, cachePath) : null;
-        }
-    }
-
-    @SuppressWarnings("unchecked")
-    private static <K, V> CacheAccess<K, V> getCacheInner(String cacheName, int maxMemoryObjects, int maxDiskObjects, String cachePath) {
-        CompositeCache<K, V> cc = cacheManager.getCache(cacheName, getCacheAttributes(maxMemoryObjects));
+        CacheAccess<K, V> cacheAccess = JCS.getInstance(cacheName, getCacheAttributes(maxMemoryObjects));
+        CompositeCache<K, V> cc = cacheAccess.getCacheControl();
 
         if (cachePath != null && cacheDirLock != null) {
@@ -203 +189 @@
                 if (cc.getAuxCaches().length == 0) {
                     cc.setAuxCaches(new AuxiliaryCache[]{DISK_CACHE_FACTORY.createCache(
-                            diskAttributes, cacheManager, null, new StandardSerializer())});
+                            diskAttributes, null, null, new StandardSerializer())});
                 }
             } catch (Exception e) { // NOPMD
@@ -211 +197 @@
             }
         }
-        return new CacheAccess<>(cc);
+        return cacheAccess;
     }
 
@@ -218 +204 @@
      */
     public static void shutdown() {
-        // use volatile semantics to get consistent object
-        CompositeCacheManager localCacheManager = cacheManager;
-        if (localCacheManager != null) {
-            localCacheManager.shutDown();
-        }
+        JCS.shutdown();
     }