Changeset 16247 in josm for trunk/src/org


Ignore:
Timestamp:
2020-04-09T17:37:48+02:00 (5 years ago)
Author:
GerdP
Message:

fix #19053: Validator does not find overlapping buildings anymore
Ignore list handling added an invalid entry for key "3000" so that all issues found by the MapCSSTagChecker were ignored

  • remove invalid entry when loading the ignore List
  • disable the Ignore button when it would produce the invalid entry
Location:
trunk/src/org/openstreetmap/josm
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

    r16091 r16247  
    235235                Logging.log(Logging.LEVEL_ERROR, "Unable to load ignored errors", e);
    236236            }
     237            // see #19053: remove invalid entry
     238            ignoredErrors.remove("3000");
    237239        }
    238240    }
  • trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java

    r16187 r16247  
    411411        lastSelectedNode = node;
    412412        if (node != null) {
     413            final Set<String> codes = new HashSet<>();
    413414            ValidatorTreePanel.visitTestErrors(node, error -> {
     415                codes.add(error.getIgnoreSubGroup()); // see #19053
    414416                error.setSelected(true);
    415417
     
    423425            selectAction.setEnabled(true);
    424426            if (ignoreAction != null) {
    425                 ignoreAction.setEnabled(!(node.getUserObject() instanceof Severity));
     427                ignoreAction.setEnabled(!(node.getUserObject() instanceof Severity) && codes.size() <= 1);
    426428            }
    427429        }
Note: See TracChangeset for help on using the changeset viewer.