Changeset 16138 in josm

Timestamp:

2020-03-15T19:15:04+01:00 (4 years ago)

Author:

Don-vip

Message:

see #18933 - toolbar code refactoring

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/CopyCoordinatesAction.java (modified) (1 diff)
• actions/ExpertToggleAction.java (modified) (1 diff)
• actions/FullscreenToggleAction.java (modified) (1 diff)
• actions/HistoryInfoAction.java (modified) (1 diff)
• actions/JosmAction.java (modified) (4 diffs)
• actions/PreferenceToggleAction.java (modified) (1 diff)
• actions/RestartAction.java (modified) (1 diff)
• actions/ShowStatusReportAction.java (modified) (1 diff)
• actions/TaggingPresetSearchAction.java (modified) (1 diff)
• actions/WireframeToggleAction.java (modified) (1 diff)
• actions/mapmode/AddNoteAction.java (modified) (3 diffs)
• gui/ImageryMenu.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/CopyCoordinatesAction.java

@@ -29 +29 @@
                 KeyEvent.VK_C, Shortcut.CTRL_SHIFT),
                 false);
-        putValue("toolbar", "copy/coordinates");
+        setToolbarId("copy/coordinates");
     }
 

trunk/src/org/openstreetmap/josm/actions/ExpertToggleAction.java

@@ -115 +115 @@
               false /* register toolbar */
         );
-        putValue("toolbar", "expertmode");
+        setToolbarId("expertmode");
         if (MainApplication.getToolbar() != null) {
             MainApplication.getToolbar().register(this);

trunk/src/org/openstreetmap/josm/actions/FullscreenToggleAction.java

@@ -44 +44 @@
         );
         setHelpId(ht("/Action/FullscreenView"));
-        putValue("toolbar", "fullscreen");
+        setToolbarId("fullscreen");
         MainApplication.getToolbar().register(this);
         gd = GraphicsEnvironment.isHeadless() ? null : GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice();

trunk/src/org/openstreetmap/josm/actions/HistoryInfoAction.java

@@ -36 +36 @@
                         tr("History"), KeyEvent.VK_H, Shortcut.CTRL), false);
         setHelpId(ht("/Action/ObjectHistory"));
-        putValue("toolbar", "action/historyinfo");
+        setToolbarId("action/historyinfo");
         MainApplication.getToolbar().register(this);
         setEnabled(true);

trunk/src/org/openstreetmap/josm/actions/JosmAction.java

@@ -24 +24 @@
 import org.openstreetmap.josm.gui.ConditionalOptionPaneUtil;
 import org.openstreetmap.josm.gui.MainApplication;
+import org.openstreetmap.josm.gui.help.HelpUtil;
 import org.openstreetmap.josm.gui.layer.LayerManager.LayerAddEvent;
 import org.openstreetmap.josm.gui.layer.LayerManager.LayerChangeListener;
@@ -75 +76 @@
      *            the user CANNOT configure a shortcut for your action.
      * @param registerInToolbar register this action for the toolbar preferences?
-     * @param toolbarId identifier for the toolbar preferences. The iconName is used, if this parameter is null
+     * @param toolbarId identifier for the toolbar preferences
      * @param installAdapters false, if you don't want to install layer changed and selection changed adapters
      */
@@ -99 +100 @@
         setTooltip(tooltip);
         if (getValue("toolbar") == null) {
-            putValue("toolbar", toolbarId);
+            setToolbarId(toolbarId);
         }
         if (registerInToolbar && MainApplication.getToolbar() != null) {
@@ -292 +293 @@
     }
 
+    /**
+     * Sets the help topic id.
+     * @param helpId help topic id (result of {@link HelpUtil#ht})
+     * @since 14397
+     */
     protected void setHelpId(String helpId) {
         putValue("help", helpId);
+    }
+
+    /**
+     * Sets the toolbar id.
+     * @param toolbarId toolbar id
+     * @since 16138
+     */
+    protected void setToolbarId(String toolbarId) {
+        putValue("toolbar", toolbarId);
     }
 

trunk/src/org/openstreetmap/josm/actions/PreferenceToggleAction.java

@@ -31 +31 @@
     public PreferenceToggleAction(String name, String tooltip, String prefKey, boolean prefDefault) {
         super(name, null, tooltip, null, false);
-        putValue("toolbar", "toggle-" + prefKey);
+        setToolbarId("toggle-" + prefKey);
         this.pref = new BooleanProperty(prefKey, prefDefault);
         checkbox = new JCheckBoxMenuItem(this);

trunk/src/org/openstreetmap/josm/actions/RestartAction.java

@@ -51 +51 @@
                 Shortcut.registerShortcut("file:restart", tr("File: {0}", tr("Restart")), KeyEvent.VK_J, Shortcut.ALT_CTRL_SHIFT), false);
         setHelpId(ht("/Action/Restart"));
-        putValue("toolbar", "action/restart");
+        setToolbarId("action/restart");
         if (MainApplication.getToolbar() != null) {
             MainApplication.getToolbar().register(this);

trunk/src/org/openstreetmap/josm/actions/ShowStatusReportAction.java

@@ -67 +67 @@
 
         setHelpId(ht("/Action/ShowStatusReport"));
-        putValue("toolbar", "help/showstatusreport");
+        setToolbarId("help/showstatusreport");
         MainApplication.getToolbar().register(this);
     }

trunk/src/org/openstreetmap/josm/actions/TaggingPresetSearchAction.java

@@ -24 +24 @@
         super(tr("Search preset..."), "dialogs/search", tr("Show preset search dialog"),
                 Shortcut.registerShortcut("preset:search", tr("Search presets"), KeyEvent.VK_F3, Shortcut.DIRECT), false);
-        putValue("toolbar", "presets/search");
+        setToolbarId("presets/search");
         MainApplication.getToolbar().register(this);
     }

trunk/src/org/openstreetmap/josm/actions/WireframeToggleAction.java

@@ -30 +30 @@
               false /* register toolbar */
         );
-        putValue("toolbar", "wireframe");
+        setToolbarId("wireframe");
         MainApplication.getToolbar().register(this);
         setSelected(MapRendererFactory.getInstance().isWireframeMapRendererActive());

trunk/src/org/openstreetmap/josm/actions/mapmode/AddNoteAction.java

@@ -6 +6 @@
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseEvent;
+import java.util.Objects;
 
 import javax.swing.JOptionPane;
@@ -17 +18 @@
 import org.openstreetmap.josm.gui.Notification;
 import org.openstreetmap.josm.gui.util.KeyPressReleaseListener;
-import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Logging;
@@ -37 +37 @@
         super(tr("Add a new Note"), "addnote", tr("Add note mode"),
             ImageProvider.getCursor("crosshair", "create_note"));
-        CheckParameterUtil.ensureParameterNotNull(data, "data");
-        noteData = data;
+        noteData = Objects.requireNonNull(data, "data");
     }
 

trunk/src/org/openstreetmap/josm/gui/ImageryMenu.java

@@ -56 +56 @@
         AdjustImageryOffsetAction() {
             super(tr("Imagery offset"), "mapmode/adjustimg", tr("Adjust imagery offset"), null, false, false);
-            putValue("toolbar", "imagery-offset");
+            setToolbarId("imagery-offset");
             MainApplication.getToolbar().register(this);
         }