Changeset 16041 in josm

Timestamp:

2020-03-06T00:23:29+01:00 (5 years ago)

Author:

simon04

Message:

see #18864 - TaggingPreset: use ArrayList with default capacity of 2

Reduces retained size of TaggingPreset from 1_893_976 to 1_758_840 (de).

Location:

trunk/src/org/openstreetmap/josm/gui/tagging/presets

Files:

• TaggingPreset.java (modified) (2 diffs)
• TaggingPresetNameTemplateList.java (modified) (2 diffs)
• items/Roles.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPreset.java

@@ -120 +120 @@
      */
     public transient Set<TaggingPresetType> types;
-    public final transient List<TaggingPresetItem> data = new LinkedList<>();
+    public final transient List<TaggingPresetItem> data = new ArrayList<>(2);
     public transient Roles roles;
     public transient TemplateEntry nameTemplate;
@@ -641 +641 @@
             new ImageProvider("dialogs", "pin").getResource().attachImageIcon(this, true);
             putValue(SHORT_DESCRIPTION, tr("Add or remove toolbar button"));
-            List<String> t = new LinkedList<>(ToolbarPreferences.getToolString());
+            List<String> t = new ArrayList<>(ToolbarPreferences.getToolString());
             toolbarIndex = t.indexOf(getToolbarString());
             putValue(SELECTED_KEY, toolbarIndex >= 0);

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetNameTemplateList.java

@@ -2 +2 @@
 package org.openstreetmap.josm.gui.tagging.presets;
 
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.EnumSet;
-import java.util.LinkedList;
 import java.util.List;
 
@@ -17 +17 @@
     private static TaggingPresetNameTemplateList instance;
 
-    private final List<TaggingPreset> presetsWithPattern = new LinkedList<>();
+    private final List<TaggingPreset> presetsWithPattern = new ArrayList<>();
 
     /**

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Roles.java

@@ -5 +5 @@
 
 import java.awt.GridBagLayout;
+import java.util.ArrayList;
 import java.util.Collection;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Set;
@@ -158 +158 @@
      * List of {@link Role} elements.
      */
-    public final List<Role> roles = new LinkedList<>();
+    public final List<Role> roles = new ArrayList<>(2);
 
     @Override