Changeset 15823 in josm for trunk/src

Timestamp:

2020-02-06T21:51:52+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #18678 - fix DownloadAlong with locked layers

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/DownloadAlongWayAction.java (modified) (1 diff)
• gui/layer/gpx/DownloadAlongPanel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/DownloadAlongWayAction.java

@@ -43 +43 @@
     @Override
     protected PleaseWaitRunnable createTask() {
-        Collection<Way> selectedWays = getLayerManager().getEditDataSet().getSelectedWays();
-
+        Collection<Way> selectedWays = getLayerManager().getActiveDataSet().getSelectedWays();
         if (selectedWays.isEmpty()) {
             JOptionPane.showMessageDialog(MainApplication.getMainFrame(), tr("Please select 1 or more ways to download along"));

trunk/src/org/openstreetmap/josm/gui/layer/gpx/DownloadAlongPanel.java

@@ -152 +152 @@
      * @param listener The listener that will be notified of each combobox change
      */
-    protected final void addChangeListener(ChangeListener listener) {
+    protected final void addAndFireChangeListener(ChangeListener listener) {
         cbDownloadGpxData.addChangeListener(listener);
         cbDownloadOsmData.addChangeListener(listener);
+        listener.stateChanged(null);
     }
 
@@ -185 +186 @@
         };
 
-        addChangeListener(e -> options[0].setEnabled(isDownloadOsmData() || isDownloadGpxData()));
+        addAndFireChangeListener(e -> {
+            boolean somethingToDownload = isDownloadOsmData() || isDownloadGpxData();
+            options[0].setEnabled(somethingToDownload && MainApplication.getLayerManager().getEditLayer() != null);
+            options[1].setEnabled(somethingToDownload);
+        });
 
         int ret = HelpAwareOptionPane.showOptionDialog(MainApplication.getMainFrame(), this, title,