Changeset 15818 in josm

Timestamp:

2020-02-05T22:19:42+01:00 (5 years ago)

Author:

simon04

Message:

fix #18628 - Autofilter: display active rule/key

Location:

trunk/src/org/openstreetmap/josm/gui/autofilter

Files:

• AutoFilterButton.java (modified) (2 diffs)
• AutoFilterManager.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterButton.java

@@ -8 +8 @@
 import java.awt.event.ActionEvent;
 
+import javax.swing.AbstractAction;
 import javax.swing.BorderFactory;
 import javax.swing.JButton;
 
 import org.openstreetmap.josm.actions.JosmAction;
+import org.openstreetmap.josm.actions.PreferencesAction;
 import org.openstreetmap.josm.data.preferences.NamedColorProperty;
 import org.openstreetmap.josm.gui.MainApplication;
+import org.openstreetmap.josm.gui.preferences.display.DrawingPreference;
 
 /**
@@ -63 +66 @@
         super.paintComponent(g);
     }
+
+    static AutoFilterButton forOsmKey(String key) {
+        final String name = key + ":";
+        final AutoFilterButton button = new AutoFilterButton(new AutoFilter(key, "", null));
+        button.setAction(new AbstractAction(name) {
+            @Override
+            public void actionPerformed(ActionEvent e) {
+                PreferencesAction.forPreferenceSubTab("", "null", DrawingPreference.class).actionPerformed(e);
+            }
+        });
+        return button;
+    }
 }

trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterManager.java

@@ -182 +182 @@
 
     private synchronized void addNewButtons(NavigableSet<String> values) {
+        if (values.isEmpty()) {
+            return;
+        }
         int i = 0;
         int maxWidth = 16;
-        MapView mapView = MainApplication.getMap().mapView;
+        final AutoFilterButton keyButton = AutoFilterButton.forOsmKey(enabledRule.getKey());
+        addButton(keyButton, Integer.toString(Integer.MIN_VALUE), i++);
         for (final String value : values.descendingSet()) {
             CompiledFilter filter = new CompiledFilter(enabledRule.getKey(), value);
@@ -193 +197 @@
                 button.getModel().setPressed(true);
             }
-            buttons.put(value, button);
             maxWidth = Math.max(maxWidth, button.getPreferredSize().width);
-            mapView.add(button).setLocation(3, 60 + 22*i++);
+            addButton(button, value, i++);
         }
         for (AutoFilterButton b : buttons.values()) {
-            b.setSize(maxWidth, 20);
-        }
-        mapView.validate();
+            b.setSize(b == keyButton ? b.getPreferredSize().width : maxWidth, 20);
+        }
+        MainApplication.getMap().mapView.validate();
+    }
+
+    private void addButton(AutoFilterButton button, String value, int i) {
+        MapView mapView = MainApplication.getMap().mapView;
+        buttons.put(value, button);
+        mapView.add(button).setLocation(3, 60 + 22*i);
     }