Changeset 15752 in josm for trunk/src/org

Timestamp:

2020-01-22T22:31:24+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #18523 - Upload dialog: Switch from BorderLayout to GridBagLayout (patch by taylor.smock)

File:

• trunk/src/org/openstreetmap/josm/gui/io/BasicUploadSettingsPanel.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/io/BasicUploadSettingsPanel.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
-import java.awt.BorderLayout;
 import java.awt.GridBagLayout;
 import java.awt.event.ActionEvent;
@@ -63 +62 @@
     private final HistoryComboBox hcbUploadComment = new HistoryComboBox();
     private final HistoryComboBox hcbUploadSource = new HistoryComboBox();
+    private final transient JCheckBox obtainSourceAutomatically = new JCheckBox(
+            tr("Automatically obtain source from current layers"));
     /** the panel with a summary of the upload parameters */
     private final UploadParameterSummaryPanel pnlUploadParameterSummary = new UploadParameterSummaryPanel();
@@ -94 +95 @@
             }
         });
-        JCheckBox obtainSourceAutomatically = new JCheckBox(tr("Automatically obtain source from current layers"));
         obtainSourceAutomatically.setSelected(Config.getPref().getBoolean("upload.source.obtainautomatically", false));
         obtainSourceAutomatically.addActionListener(e -> {
@@ -177 +177 @@
 
     protected void build() {
-        setLayout(new BorderLayout());
+        setLayout(new GridBagLayout());
         setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
-        add(buildUploadCommentPanel(), BorderLayout.NORTH);
-        add(pnlUploadParameterSummary, BorderLayout.CENTER);
-        add(cbRequestReview, BorderLayout.SOUTH);
+        add(buildUploadCommentPanel(), GBC.eol().fill(GBC.BOTH));
+        add(pnlUploadParameterSummary, GBC.eol().fill(GBC.HORIZONTAL));
+        add(cbRequestReview, GBC.eol().fill(GBC.HORIZONTAL));
         cbRequestReview.addItemListener(e -> changesetReviewModel.setReviewRequested(e.getStateChange() == ItemEvent.SELECTED));
     }
@@ -228 +228 @@
         hcbUploadSource.addCurrentItemToHistory();
         Config.getPref().putList(SOURCE_HISTORY_KEY, hcbUploadSource.getHistory());
+
+        // store current value of obtaining source automatically
+        Config.getPref().putBoolean("upload.source.obtainautomatically", obtainSourceAutomatically.isSelected());
     }