Changeset 15633 in josm for trunk

Timestamp:

2020-01-05T16:36:31+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #18514 - make all changeset actions and dialogs only accessible in expert mode

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• HideableButton.java (modified) (1 diff)
• IconToggleButton.java (modified) (1 diff)
• MainMenu.java (modified) (7 diffs)
• MapFrame.java (modified) (2 diffs)
• dialogs/ToggleDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/HideableButton.java

@@ -23 +23 @@
     boolean isButtonVisible();
 
+    boolean isExpert();
+
     void setShowHideButtonListener(ShowHideButtonListener l);
 }

trunk/src/org/openstreetmap/josm/gui/IconToggleButton.java

@@ -162 +162 @@
 
     @Override
+    public boolean isExpert() {
+        return isExpert;
+    }
+
+    @Override
     public void setShowHideButtonListener(ShowHideButtonListener l) {
         listener = l;

trunk/src/org/openstreetmap/josm/gui/MainMenu.java

@@ -448 +448 @@
             final JPopupMenu m = ((JMenu) a.getSource()).getPopupMenu();
             for (int i = 0; i < m.getComponentCount()-1; i++) {
-                if (!(m.getComponent(i) instanceof JSeparator)) {
-                    continue;
+                // hide separator if the next menu item is one as well
+                if (m.getComponent(i) instanceof JSeparator && m.getComponent(i+1) instanceof JSeparator) {
+                    ((JSeparator) m.getComponent(i)).setVisible(false);
                 }
-                // hide separator if the next menu item is one as well
-                ((JSeparator) m.getComponent(i)).setVisible(!(m.getComponent(i+1) instanceof JSeparator));
             }
             // hide separator at the end of the menu
@@ -566 +565 @@
         if (action.getShortcut().isAutomatic())
             return null;
-        int i = getInsertionIndexForGroup(menu, group.ordinal());
+        int i = getInsertionIndexForGroup(menu, group.ordinal(), false);
         JMenuItem menuitem = (JMenuItem) menu.add(new JMenuItem(action), i);
         KeyStroke ks = action.getShortcut().getKeyStroke();
@@ -587 +586 @@
      */
     public static <E extends Enum<E>> JCheckBoxMenuItem addWithCheckbox(JMenu menu, JosmAction action, Enum<E> group) {
-        int i = getInsertionIndexForGroup(menu, group.ordinal());
+        return addWithCheckbox(menu, action, group, false, false);
+    }
+
+    /**
+     * Add a JosmAction to a menu and automatically prints accelerator if available.
+     * Also adds a checkbox that may be toggled.
+     * @param <E> group enum item type
+     * @param menu to add the action to
+     * @param action the action that should get a menu item
+     * @param group the item should be added to. Groups are split by a separator. Use
+     *        one of the enums that are defined for some of the menus to tell in which
+     *        group the item should go.
+     * @param isEntryExpert whether the entry should only be visible if the expert mode is activated
+     * @param isGroupSeparatorExpert whether the group separator should only be visible if the expert mode is activated
+     * @return The created menu item
+     * @since 15633
+     */
+    public static <E extends Enum<E>> JCheckBoxMenuItem addWithCheckbox(JMenu menu, JosmAction action, Enum<E> group,
+            boolean isEntryExpert, boolean isGroupSeparatorExpert) {
+        int i = getInsertionIndexForGroup(menu, group.ordinal(), isGroupSeparatorExpert);
         final JCheckBoxMenuItem mi = (JCheckBoxMenuItem) menu.add(new JCheckBoxMenuItem(action), i);
         final KeyStroke ks = action.getShortcut().getKeyStroke();
@@ -593 +611 @@
             mi.setAccelerator(ks);
         }
+        if (isEntryExpert) {
+            ExpertToggleAction.addVisibilitySwitcher(mi);
+        }
         return mi;
     }
@@ -600 +621 @@
      * @param menu menu
      * @param group group number
+     * @param isGroupSeparatorExpert whether the added separators should only be visible if the expert mode is activated
      * @return correct insertion index
      */
-    private static int getInsertionIndexForGroup(JMenu menu, int group) {
+    private static int getInsertionIndexForGroup(JMenu menu, int group, boolean isGroupSeparatorExpert) {
         if (group < 0)
             return -1;
@@ -619 +641 @@
         while (group > 0) {
             menu.addSeparator();
+            if (isGroupSeparatorExpert) {
+                ExpertToggleAction.addVisibilitySwitcher(menu.getMenuComponent(menu.getMenuComponentCount() - 1));
+            }
             group--;
             i++;
@@ -832 +857 @@
         // -- changeset manager toggle action
         final JCheckBoxMenuItem mi = MainMenu.addWithCheckbox(windowMenu, changesetManager,
-                MainMenu.WINDOW_MENU_GROUP.ALWAYS);
+                MainMenu.WINDOW_MENU_GROUP.ALWAYS, true, false);
         changesetManager.addButtonModel(mi.getModel());
 

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -44 +44 @@
 import javax.swing.plaf.basic.BasicSplitPaneUI;
 
+import org.openstreetmap.josm.actions.ExpertToggleAction;
 import org.openstreetmap.josm.actions.mapmode.DeleteAction;
 import org.openstreetmap.josm.actions.mapmode.DrawAction;
@@ -671 +672 @@
             JPopupMenu menu = new JPopupMenu();
             for (HideableButton b : buttons) {
-                final HideableButton t = b;
-                menu.add(new JCheckBoxMenuItem(new AbstractAction() {
-                    {
-                        putValue(NAME, t.getActionName());
-                        putValue(SMALL_ICON, t.getIcon());
-                        putValue(SELECTED_KEY, t.isButtonVisible());
-                        putValue(SHORT_DESCRIPTION, tr("Hide or show this toggle button"));
-                    }
-
-                    @Override
-                    public void actionPerformed(ActionEvent e) {
-                        if ((Boolean) getValue(SELECTED_KEY)) {
-                            t.showButton();
-                        } else {
-                            t.hideButton();
+                if (!b.isExpert() || ExpertToggleAction.isExpert()) {
+                    final HideableButton t = b;
+                    menu.add(new JCheckBoxMenuItem(new AbstractAction() {
+                        {
+                            putValue(NAME, t.getActionName());
+                            putValue(SMALL_ICON, t.getIcon());
+                            putValue(SELECTED_KEY, t.isButtonVisible());
+                            putValue(SHORT_DESCRIPTION, tr("Hide or show this toggle button"));
                         }
-                        validateToolBarsVisibility();
-                    }
-                }));
+
+                        @Override
+                        public void actionPerformed(ActionEvent e) {
+                            if ((Boolean) getValue(SELECTED_KEY)) {
+                                t.showButton();
+                            } else {
+                                t.hideButton();
+                            }
+                            validateToolBarsVisibility();
+                        }
+                    }));
+                }
             }
             if (button != null && button.isShowing()) {

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -266 +266 @@
         windowMenuItem = MainMenu.addWithCheckbox(MainApplication.getMenu().windowMenu,
                 (JosmAction) getToggleAction(),
-                MainMenu.WINDOW_MENU_GROUP.TOGGLE_DIALOG);
+                MainMenu.WINDOW_MENU_GROUP.TOGGLE_DIALOG, false, true);
     }