Changeset 15603 in josm for trunk

Timestamp:

2019-12-21T03:15:48+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #18441 - Allow plugins to remove a test they added (patch by taylor.smock)

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/validation/OsmValidator.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/validation/OsmValidatorTest.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -166 +166 @@
     }
 
+    /**
+     * Removes a test from the list of available tests. This will not remove
+     * core tests.
+     *
+     * @param testClass The test class
+     * @return {@code true} if the test was removed (see {@link Collection#remove})
+     * @since 15603
+     */
+    public static boolean removeTest(Class<? extends Test> testClass) {
+        boolean removed = false;
+        if (!Arrays.asList(CORE_TEST_CLASSES).contains(testClass)) {
+            removed = allTests.remove(testClass);
+            allTestsMap.remove(testClass.getName());
+        }
+        return removed;
+    }
+
     static {
         for (Class<? extends Test> testClass : CORE_TEST_CLASSES) {

trunk/test/unit/org/openstreetmap/josm/data/validation/OsmValidatorTest.java

@@ -3 +3 @@
 
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertTrue;
 
@@ -8 +9 @@
 import org.junit.Rule;
 import org.junit.Test;
+import org.openstreetmap.josm.data.validation.tests.Addresses;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
 
@@ -84 +86 @@
     }
 
+    /**
+     * Test that tests are really removed, and that core tests cannot be removed
+     */
+    @Test
+    public void testRemoveTests() {
+        org.openstreetmap.josm.data.validation.Test test = new org.openstreetmap.josm.data.validation.Test("test") {
+        };
+        assertNotEquals(org.openstreetmap.josm.data.validation.Test.class, test.getClass());
+        OsmValidator.addTest(test.getClass());
+        assertTrue(OsmValidator.getAllAvailableTestClasses().contains(test.getClass()));
+        assertTrue(OsmValidator.removeTest(test.getClass()));
+        assertFalse(OsmValidator.removeTest(test.getClass()));
+        assertFalse(OsmValidator.getAllAvailableTestClasses().contains(test.getClass()));
+
+        assertTrue(OsmValidator.getAllAvailableTestClasses().contains(Addresses.class));
+        assertFalse(OsmValidator.removeTest(Addresses.class));
+        assertTrue(OsmValidator.getAllAvailableTestClasses().contains(Addresses.class));
+    }
+
 }