Changeset 15590 in josm for trunk/src/org

Timestamp:

2019-12-13T23:03:18+01:00 (5 years ago)

Author:

Don-vip

Message:

fix PMD warnings forgotten in previous commit

Location:

trunk/src/org/openstreetmap/josm/tools

Files:

• ImageProvider.java (modified) (4 diffs)
• Logging.java (modified) (1 diff)
• PlatformHookWindows.java (modified) (1 diff)
• Utils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -1709 +1709 @@
         }
 
-        ImageInputStream stream = createImageInputStream(input);
+        ImageInputStream stream = createImageInputStream(input); // NOPMD
         if (stream == null) {
             throw new IIOException("Can't create an ImageInputStream!");
@@ -1759 +1759 @@
         CheckParameterUtil.ensureParameterNotNull(input, "input");
 
-        ImageInputStream stream = createImageInputStream(input);
+        ImageInputStream stream = createImageInputStream(input); // NOPMD
         BufferedImage bi = read(stream, readMetadata, enforceTransparency);
         if (bi == null) {
@@ -1803 +1803 @@
 
         try (InputStream istream = Utils.openStream(input)) {
-            ImageInputStream stream = createImageInputStream(istream);
+            ImageInputStream stream = createImageInputStream(istream); // NOPMD
             BufferedImage bi = read(stream, readMetadata, enforceTransparency);
             if (bi == null) {
@@ -1854 +1854 @@
         reader.setInput(stream, true, !readMetadata && !enforceTransparency);
         BufferedImage bi = null;
-        try {
+        try { // NOPMD
             bi = reader.read(0, param);
             if (bi.getTransparency() != Transparency.TRANSLUCENT && (readMetadata || enforceTransparency) && Utils.getJavaVersion() < 11) {

trunk/src/org/openstreetmap/josm/tools/Logging.java

@@ -95 +95 @@
          */
         public synchronized void reacquireOutputStream() {
-            final OutputStream reacquiredStream = this.outputStreamSupplier.get();
+            final OutputStream reacquiredStream = this.outputStreamSupplier.get(); // NOPMD
 
             // only bother calling setOutputStream if it's actually different, as setOutputStream

trunk/src/org/openstreetmap/josm/tools/PlatformHookWindows.java

@@ -440 +440 @@
             File cachePath = Config.getDirs().getCacheDirectory(true);
             Path fontconfigFile = cachePath.toPath().resolve("fontconfig.properties");
-            OutputStream os = Files.newOutputStream(fontconfigFile);
+            OutputStream os = Files.newOutputStream(fontconfigFile); // NOPMD
             os.write(content);
             try (Writer w = new BufferedWriter(new OutputStreamWriter(os, StandardCharsets.UTF_8))) {

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -1470 +1470 @@
      */
     public static byte[] readBytesFromStream(InputStream stream) throws IOException {
+        // TODO: remove this method when switching to Java 11 and use InputStream.readAllBytes
         if (stream == null) {
             return new byte[0];
         }
-        try {
+        try { // NOPMD
             ByteArrayOutputStream bout = new ByteArrayOutputStream(stream.available());
             byte[] buffer = new byte[8192];