Changeset 15117 in josm for trunk/src/org/openstreetmap

Timestamp:

2019-05-26T19:47:06+02:00 (5 years ago)

Author:

Don-vip

Message:

make sure upload comments are not remembered if upload.comment.max-age is <= 0

Location:

trunk/src/org/openstreetmap/josm/gui/io

Files:

• BasicUploadSettingsPanel.java (modified) (4 diffs)
• UploadDialog.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/io/BasicUploadSettingsPanel.java

@@ -19 +19 @@
 import java.util.concurrent.TimeUnit;
 
-import javax.swing.Action;
 import javax.swing.BorderFactory;
 import javax.swing.JCheckBox;
@@ -162 +161 @@
     }
 
-    public void setUploadTagDownFocusTraversalHandlers(final Action handler) {
+    void setUploadTagDownFocusTraversalHandlers(final ActionListener handler) {
         setHistoryComboBoxDownFocusTraversalHandler(handler, hcbUploadComment);
         setHistoryComboBoxDownFocusTraversalHandler(handler, hcbUploadSource);
     }
 
-    public void setHistoryComboBoxDownFocusTraversalHandler(final Action handler, final HistoryComboBox hcb) {
+    private static void setHistoryComboBoxDownFocusTraversalHandler(ActionListener handler, HistoryComboBox hcb) {
         hcb.getEditor().addActionListener(handler);
         hcb.getEditorComponent().addKeyListener(new HistoryComboBoxKeyAdapter(hcb, handler));
@@ -177 +176 @@
     public void rememberUserInput() {
         // store the history of comments
-        hcbUploadComment.addCurrentItemToHistory();
-        Config.getPref().putList(HISTORY_KEY, hcbUploadComment.getHistory());
-        Config.getPref().putLong(HISTORY_LAST_USED_KEY, TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis()));
+        if (getHistoryMaxAgeKey() > 0) {
+            hcbUploadComment.addCurrentItemToHistory();
+            Config.getPref().putList(HISTORY_KEY, hcbUploadComment.getHistory());
+            Config.getPref().putLong(HISTORY_LAST_USED_KEY, TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis()));
+        }
         // store the history of sources
         hcbUploadSource.addCurrentItemToHistory();
@@ -232 +233 @@
     }
 
+    static long getHistoryMaxAgeKey() {
+        return Config.getPref().getLong(HISTORY_MAX_AGE_KEY, TimeUnit.HOURS.toSeconds(4));
+    }
+
+    static long getHistoryLastUsedKey() {
+        return Config.getPref().getLong(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, 0);
+    }
+
     static final class HistoryComboBoxKeyAdapter extends KeyAdapter {
         private final HistoryComboBox hcb;
-        private final Action handler;
-
-        HistoryComboBoxKeyAdapter(HistoryComboBox hcb, Action handler) {
+        private final ActionListener handler;
+
+        HistoryComboBoxKeyAdapter(HistoryComboBox hcb, ActionListener handler) {
             this.hcb = hcb;
             this.handler = handler;

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -27 +27 @@
 import java.util.Map.Entry;
 import java.util.Optional;
-import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
@@ -238 +237 @@
         );
 
-        pnlBasicUploadSettings.setUploadTagDownFocusTraversalHandlers(
-                new AbstractAction() {
-                    @Override
-                    public void actionPerformed(ActionEvent e) {
-                        btnUpload.requestFocusInWindow();
-                    }
-                }
-        );
+        pnlBasicUploadSettings.setUploadTagDownFocusTraversalHandlers(e -> btnUpload.requestFocusInWindow());
 
         setMinimumSize(new Dimension(600, 350));
@@ -778 +770 @@
     private static String getLastChangesetTagFromHistory(String historyKey, List<String> def) {
         Collection<String> history = Config.getPref().getList(historyKey, def);
-        long age = System.currentTimeMillis() / 1000 - Config.getPref().getLong(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, 0);
-        if (age < Config.getPref().getLong(BasicUploadSettingsPanel.HISTORY_MAX_AGE_KEY, TimeUnit.HOURS.toSeconds(4))
-                && !history.isEmpty()) {
+        long age = System.currentTimeMillis() / 1000 - BasicUploadSettingsPanel.getHistoryLastUsedKey();
+        if (age < BasicUploadSettingsPanel.getHistoryMaxAgeKey() && !history.isEmpty()) {
             return history.iterator().next();
         }