Changeset 14866 in josm for trunk/src/org

Timestamp:

2019-03-09T20:43:09+01:00 (6 years ago)

Author:

GerdP

Message:

fix some sonar issues

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• AboutAction.java (modified) (1 diff)
• AddImageryLayerAction.java (modified) (1 diff)
• ImageryAdjustAction.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/actions/AboutAction.java

@@ -67 +67 @@
     }
 
-    protected JPanel buildAboutPanel() {
+    JPanel buildAboutPanel() {
         final JTabbedPane about = new JTabbedPane();
 

trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java

@@ -284 +284 @@
     @Override
     protected void updateEnabledState() {
-        if (info.isBlacklisted()) {
-            setEnabled(false);
-        } else {
-            setEnabled(true);
-        }
+        setEnabled(!info.isBlacklisted());
     }
 

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -44 +44 @@
  */
 public class ImageryAdjustAction extends MapMode implements AWTEventListener {
-    private static volatile ImageryOffsetDialog offsetDialog;
-    private static Cursor cursor = ImageProvider.getCursor("normal", "move");
-
-    private OffsetBookmark old;
-    private OffsetBookmark tempOffset;
+    private static ImageryOffsetDialog offsetDialog;
+
+    private transient OffsetBookmark old;
+    private transient OffsetBookmark tempOffset;
     private EastNorth prevEastNorth;
     private transient AbstractTileSourceLayer<?> layer;
@@ -60 +59 @@
      */
     public ImageryAdjustAction(AbstractTileSourceLayer<?> layer) {
-        super(tr("New offset"), "adjustimg", tr("Adjust the position of this imagery layer"), cursor);
+        super(tr("New offset"), "adjustimg", tr("Adjust the position of this imagery layer"),
+                ImageProvider.getCursor("normal", "move"));
         putValue("toolbar", Boolean.FALSE);
         this.layer = layer;
@@ -118 +118 @@
         restoreOldMode = false;
         doExitMode();
-    }
-
-    private void exitModeAndRestoreOldMode() {
-        restoreOldMode = true;
-        doExitMode();
-        restoreOldMode = false;
     }
 
@@ -241 +235 @@
     private static final class ConfirmOverwriteBookmarkDialog extends ExtendedDialog {
         ConfirmOverwriteBookmarkDialog() {
-            super(MainApplication.getMainFrame(), tr("Overwrite"), new String[] {tr("Overwrite"), tr("Cancel")});
+            super(MainApplication.getMainFrame(), tr("Overwrite"), tr("Overwrite"), tr("Cancel"));
             contentInsets = new Insets(10, 15, 10, 15);
             setContent(tr("Offset bookmark already exists. Overwrite?"));
@@ -381 +375 @@
             }
         }
+
+        private void exitModeAndRestoreOldMode() {
+            restoreOldMode = true;
+            doExitMode();
+            restoreOldMode = false;
+        }
     }