Changeset 14797 in josm

Timestamp:

2019-02-22T22:35:25+01:00 (6 years ago)

Author:

Don-vip

Message:

fix #17367 - NPE

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/gpx/GpxImageCorrelationTest.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/gpx/GpxImageCorrelation.java

@@ -176 +176 @@
     }
 
-    private static Double getElevation(WayPoint wp) {
-        String value = wp.getString(GpxConstants.PT_ELE);
-        if (value != null && !value.isEmpty()) {
-            try {
-                return Double.valueOf(value);
-            } catch (NumberFormatException e) {
-                Logging.warn(e);
+    static Double getElevation(WayPoint wp) {
+        if (wp != null) {
+            String value = wp.getString(GpxConstants.PT_ELE);
+            if (value != null && !value.isEmpty()) {
+                try {
+                    return Double.valueOf(value);
+                } catch (NumberFormatException e) {
+                    Logging.warn(e);
+                }
             }
         }

trunk/test/unit/org/openstreetmap/josm/data/gpx/GpxImageCorrelationTest.java

@@ -4 +4 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
@@ -14 +15 @@
 import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.data.coor.CachedLatLon;
+import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.io.GpxReaderTest;
 import org.openstreetmap.josm.spi.preferences.Config;
@@ -267 +269 @@
         }
     }
+
+    /**
+     * Unit test of {@link GpxImageCorrelation#getElevation}
+     */
+    @Test
+    public void testGetElevation() {
+        assertNull(GpxImageCorrelation.getElevation(null));
+        WayPoint wp = new WayPoint(LatLon.ZERO);
+        assertNull(GpxImageCorrelation.getElevation(wp));
+        wp.put(GpxConstants.PT_ELE, "");
+        assertNull(GpxImageCorrelation.getElevation(wp));
+        wp.put(GpxConstants.PT_ELE, "not a number");
+        assertNull(GpxImageCorrelation.getElevation(wp));
+        wp.put(GpxConstants.PT_ELE, "150.0");
+        assertEquals(Double.valueOf(150.0d), GpxImageCorrelation.getElevation(wp));
+    }
 }