Changeset 14721 in josm

Timestamp:

2019-01-23T07:35:49+01:00 (6 years ago)

Author:

GerdP

Message:

fix PMD issue: The final local variable name 'ERR_TYPE_SPACE' doesn't match '[a-z][a-zA-Z0-9]*'.

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -550 +550 @@
             withErrors.put(p, "EV");
         }
-        final String ERR_TYPE_SPACE = "SPACE";
-        if ((value.startsWith(" ") || value.endsWith(" ")) && !withErrors.contains(p, ERR_TYPE_SPACE)) {
+        final String errTypeSpace = "SPACE";
+        if ((value.startsWith(" ") || value.endsWith(" ")) && !withErrors.contains(p, errTypeSpace)) {
             errors.add(TestError.builder(this, Severity.WARNING, INVALID_SPACE)
                     .message(tr("Property values start or end with white space"), s, key)
                     .primitives(p)
                     .build());
-            withErrors.put(p, ERR_TYPE_SPACE);
-        }
-        if (value.contains("  ") && !withErrors.contains(p, ERR_TYPE_SPACE)) {
+            withErrors.put(p, errTypeSpace);
+        }
+        if (value.contains("  ") && !withErrors.contains(p, errTypeSpace)) {
             errors.add(TestError.builder(this, Severity.WARNING, MULTIPLE_SPACES)
                     .message(tr("Property values contain multiple white spaces"), s, key)
                     .primitives(p)
                     .build());
-            withErrors.put(p, ERR_TYPE_SPACE);
+            withErrors.put(p, errTypeSpace);
         }
         if (!value.equals(Entities.unescape(value)) && !withErrors.contains(p, "HTML")) {