Changeset 14535 in josm for trunk/src

Timestamp:

2018-12-09T20:06:53+01:00 (6 years ago)

Author:

Don-vip

Message:

see #16073 - check response contents
see #16854 - stability of created primitive IDs (accidental commit...)

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/cache/JCSCachedTileLoaderJob.java (modified) (1 diff)
• data/imagery/TMSCachedTileLoaderJob.java (modified) (2 diffs)
• io/AbstractReader.java (modified) (6 diffs)
• io/CachedFile.java (modified) (2 diffs)
• tools/Utils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/cache/JCSCachedTileLoaderJob.java

@@ -420 +420 @@
     }
 
-    protected String detectErrorMessage(String data) {
+    /**
+     * Tries do detect an error message from given string.
+     * @param data string to analyze
+     * @return error message if detected, or null
+     * @since 14535
+     */
+    public String detectErrorMessage(String data) {
         Matcher m = HttpClient.getTomcatErrorMatcher(data);
         return m.matches() ? m.group(1).replace("'", "''") : null;

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

@@ -67 +67 @@
      * @param downloadExecutor that will be executing the jobs
      */
-
     public TMSCachedTileLoaderJob(TileLoaderListener listener, Tile tile,
             ICacheAccess<String, BufferedImageCacheEntry> cache,
@@ -321 +320 @@
 
     @Override
-    protected String detectErrorMessage(String data) {
+    public String detectErrorMessage(String data) {
         Matcher m = SERVICE_EXCEPTION_PATTERN.matcher(data);
         return m.matches() ? removeCdata(Utils.strip(m.group(1))) : super.detectErrorMessage(data);

trunk/src/org/openstreetmap/josm/io/AbstractReader.java

@@ -14 +14 @@
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.OptionalLong;
 import java.util.function.Consumer;
 
@@ -323 +324 @@
             throw new IllegalDataException(e);
         } finally {
+            OptionalLong minId = externalIdMap.values().stream().mapToLong(AbstractPrimitive::getUniqueId).min();
+            if (minId.isPresent() && minId.getAsLong() < AbstractPrimitive.currentUniqueId()) {
+                AbstractPrimitive.advanceUniqueId(minId.getAsLong());
+            }
             progressMonitor.finishTask();
             progressMonitor.removeCancelListener(cancelListener);
@@ -604 +609 @@
     }
 
+    @SuppressWarnings("unchecked")
+    private <T extends OsmPrimitive> T buildPrimitive(PrimitiveData pd) {
+        OsmPrimitive p;
+        if (pd.getUniqueId() < AbstractPrimitive.currentUniqueId()) {
+            p = pd.getType().newInstance(pd.getUniqueId(), true);
+        } else {
+            p = pd.getType().newVersionedInstance(pd.getId(), pd.getVersion());
+        }
+        p.setVisible(pd.isVisible());
+        p.load(pd);
+        externalIdMap.put(pd.getPrimitiveId(), p);
+        return (T) p;
+    }
+
     private Node addNode(NodeData nd, NodeReader nodeReader) throws IllegalDataException {
-        Node n = new Node(nd.getId(), nd.getVersion());
-        n.setVisible(nd.isVisible());
-        n.load(nd);
+        Node n = buildPrimitive(nd);
         nodeReader.accept(n);
-        externalIdMap.put(nd.getPrimitiveId(), n);
         return n;
     }
@@ -615 +631 @@
     protected final Node parseNode(double lat, double lon, CommonReader commonReader, NodeReader nodeReader)
             throws IllegalDataException {
-        NodeData nd = new NodeData();
+        NodeData nd = new NodeData(0);
         LatLon ll = null;
         if (areLatLonDefined(lat, lon)) {
@@ -654 +670 @@
 
     protected final Way parseWay(CommonReader commonReader, WayReader wayReader) throws IllegalDataException {
-        WayData wd = new WayData();
+        WayData wd = new WayData(0);
         commonReader.accept(wd);
-        Way w = new Way(wd.getId(), wd.getVersion());
-        w.setVisible(wd.isVisible());
-        w.load(wd);
-        externalIdMap.put(wd.getPrimitiveId(), w);
+        Way w = buildPrimitive(wd);
 
         Collection<Long> nodeIds = new ArrayList<>();
@@ -672 +685 @@
 
     protected final Relation parseRelation(CommonReader commonReader, RelationReader relationReader) throws IllegalDataException {
-        RelationData rd = new RelationData();
+        RelationData rd = new RelationData(0);
         commonReader.accept(rd);
-        Relation r = new Relation(rd.getId(), rd.getVersion());
-        r.setVisible(rd.isVisible());
-        r.load(rd);
-        externalIdMap.put(rd.getPrimitiveId(), r);
+        Relation r = buildPrimitive(rd);
 
         Collection<RelationMemberData> members = new ArrayList<>();

trunk/src/org/openstreetmap/josm/io/CachedFile.java

@@ -5 +5 @@
 
 import java.io.BufferedReader;
-import java.io.ByteArrayOutputStream;
 import java.io.Closeable;
 import java.io.File;
@@ -245 +244 @@
      */
     public byte[] getByteContent() throws IOException {
-        try (InputStream is = getInputStream()) {
-            ByteArrayOutputStream buffer = new ByteArrayOutputStream();
-            int nRead;
-            byte[] data = new byte[8192];
-            while ((nRead = is.read(data, 0, data.length)) != -1) {
-                buffer.write(data, 0, nRead);
-            }
-            buffer.flush();
-            return buffer.toByteArray();
-        }
+        return Utils.readBytesFromStream(getInputStream());
     }
 

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -1447 +1447 @@
         try {
             ByteArrayOutputStream bout = new ByteArrayOutputStream(stream.available());
-            byte[] buffer = new byte[2048];
+            byte[] buffer = new byte[8192];
             boolean finished = false;
             do {