Changeset 14531 in josm for trunk/src/org/openstreetmap

Timestamp:

2018-12-09T08:15:46+01:00 (6 years ago)

Author:

GerdP

Message:

see #17055 improve TagChecker: Don't say "looks like" when all characters of given value are different, e.g. "Value '10' for key 'fee' looks like 'no'." makes no sense. The Levenshtein distance from 10 to no is only 2, but the length is also only 2.

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -547 +547 @@
                             if (possibleVal.isEmpty())
                                 continue;
+                            maxPresetValueLen = Math.max(maxPresetValueLen, possibleVal.length());
                             if (harmonizedValue.length() < 3 && possibleVal.length() >= harmonizedValue.length() + MAX_LEVENSHTEIN_DISTANCE) {
                                 // don't suggest fix value when given value is short and lengths are too different
@@ -552 +553 @@
                                 continue;
                             }
-                            maxPresetValueLen = Math.max(maxPresetValueLen, possibleVal.length());
                             int dist = Utils.getLevenshteinDistance(possibleVal, harmonizedValue);
+                            if (dist >= harmonizedValue.length()) {
+                                // short value, all characters are different. Don't warn, might say Value '10' for key 'fee' looks like 'no'.
+                                continue;
+                            }
                             if (dist < minDist) {
                                 closest = possibleVal;