Changeset 14446 in josm for trunk/src

Timestamp:

2018-11-24T15:00:43+01:00 (6 years ago)

Author:

Don-vip

Message:

see #16995 - use_Date exclusively for PT_TIME attribute (patch by cmuelle8)

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/gpx/WayPoint.java (modified) (1 diff)
• gui/layer/gpx/ConvertFromGpxLayerAction.java (modified) (2 diffs)
• gui/layer/markerlayer/Marker.java (modified) (2 diffs)
• io/GpxReader.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/gpx/WayPoint.java

@@ -179 +179 @@
                 time = date.getTime() / 1000.;
                 return date;
+            } else if (obj == null) {
+                Logging.info("Waypoint {0} value unset", PT_TIME);
             } else {
                 Logging.warn("Unsupported waypoint {0} value: {1}", PT_TIME, obj);

trunk/src/org/openstreetmap/josm/gui/layer/gpx/ConvertFromGpxLayerAction.java

@@ -34 +34 @@
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.tools.GBC;
-import org.openstreetmap.josm.tools.Logging;
-import org.openstreetmap.josm.tools.UncheckedParseException;
 import org.openstreetmap.josm.tools.date.DateUtils;
 
@@ -81 +79 @@
                                 n.put(key, str);
                             }
-                            if (GpxConstants.PT_TIME.equals(key)) {
-                                // timestamps should always be converted
-                                try {
-                                    n.setTimestamp(DateUtils.fromString(str));
-                                } catch (UncheckedParseException e) {
-                                    Logging.log(Logging.LEVEL_WARN, e);
-                                }
-                            }
                         } else if (obj instanceof Date && GpxConstants.PT_TIME.equals(key)) {
                             // timestamps should always be converted

trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java

@@ -13 +13 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Date;
 import java.util.HashMap;
 import java.util.LinkedList;
@@ -260 +259 @@
     public WayPoint convertToWayPoint() {
         WayPoint wpt = new WayPoint(getCoor());
-        wpt.put(GpxConstants.PT_TIME, timeFormatter.format(new Date(Math.round(time * 1000))));
+        wpt.setTime((long) (time*1000));
         if (text != null) {
             wpt.addExtension("text", text);

trunk/src/org/openstreetmap/josm/io/GpxReader.java

@@ -27 +27 @@
 import org.openstreetmap.josm.data.gpx.WayPoint;
 import org.openstreetmap.josm.tools.Logging;
+import org.openstreetmap.josm.tools.UncheckedParseException;
 import org.openstreetmap.josm.tools.XmlUtils;
+import org.openstreetmap.josm.tools.date.DateUtils;
 import org.xml.sax.Attributes;
 import org.xml.sax.InputSource;
@@ -441 +443 @@
                     }
                     break;
-                case "time":
+                case GpxConstants.PT_TIME:
+                    try {
+                        currentWayPoint.setTime(DateUtils.fromString(accumulator.toString()));
+                    } catch (UncheckedParseException e) {
+                        Logging.error(e);
+                    }
+                    break;
                 case "cmt":
                 case "desc":
                     currentWayPoint.put(localName, accumulator.toString());
-                    currentWayPoint.setTimeFromAttribute();
                     break;
                 case "rtept":