Changeset 14330 in josm

Timestamp:

2018-10-14T16:51:50+02:00 (6 years ago)

Author:

Don-vip

Message:

fix SonarQube issues

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/UnGlueAction.java (modified) (2 diffs)
• gui/bbox/SlippyMapBBoxChooser.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java

@@ -175 +175 @@
     }
 
-    void update(PropertiesMembershipChoiceDialog dialog, Node existingNode, List<Node> newNodes, Collection<Command> cmds) {
+    static void update(PropertiesMembershipChoiceDialog dialog, Node existingNode, List<Node> newNodes, Collection<Command> cmds) {
         updateMemberships(dialog.getMemberships(), existingNode, newNodes, cmds);
         updateProperties(dialog.getTags(), existingNode, newNodes, cmds);
     }
 
-    private void updateProperties(ExistingBothNewChoice tags, Node existingNode, Iterable<Node> newNodes, Collection<Command> cmds) {
+    private static void updateProperties(ExistingBothNewChoice tags, Node existingNode, Iterable<Node> newNodes, Collection<Command> cmds) {
         if (tags != null && tags.newNode.isSelected()) {
             final Node newSelectedNode = new Node(existingNode);
@@ -192 +192 @@
     }
 
-    private void updateMemberships(ExistingBothNewChoice memberships, Node existingNode, List<Node> newNodes, Collection<Command> cmds) {
+    private static void updateMemberships(ExistingBothNewChoice memberships, Node existingNode, List<Node> newNodes, Collection<Command> cmds) {
         if (memberships != null && memberships.bothNodes.isSelected()) {
             fixRelations(existingNode, cmds, newNodes, false);

trunk/src/org/openstreetmap/josm/gui/bbox/SlippyMapBBoxChooser.java

@@ -474 +474 @@
 
     @Override
-    public void layerOrderChanged(MainLayerManager.LayerOrderChangeEvent e) {}
+    public void layerOrderChanged(MainLayerManager.LayerOrderChangeEvent e) {
+        // Do nothing
+    }
 }