Changeset 14290 in josm for trunk

Timestamp:

2018-10-03T20:39:59+02:00 (6 years ago)

Author:

Don-vip

Message:

fix #16797 - NPE

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/tagging/presets/TaggingPreset.java (modified) (1 diff)
• tools/ImageProvider.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPreset.java

@@ -210 +210 @@
     public void setIcon(final String iconName) {
         this.iconName = iconName;
-        if (!TaggingPresetReader.isLoadIcons()) {
+        if (iconName == null || !TaggingPresetReader.isLoadIcons()) {
             return;
         }

trunk/src/org/openstreetmap/josm/tools/ImageProvider.java

@@ -41 +41 @@
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 import java.util.TreeSet;
@@ -277 +278 @@
     protected String subdir;
     /** image file name */
-    protected String name;
+    protected final String name;
     /** archive file to take image from */
     protected File archive;
@@ -327 +328 @@
      * @param name the name of the image. If it does not end with '.png' or '.svg',
      * both extensions are tried.
+     * @throws NullPointerException if name is null
      */
     public ImageProvider(String subdir, String name) {
         this.subdir = subdir;
-        this.name = name;
+        this.name = Objects.requireNonNull(name, "name");
     }
 
@@ -337 +339 @@
      * @param name the name of the image. If it does not end with '.png' or '.svg',
      * both extensions are tried.
+     * @throws NullPointerException if name is null
      */
     public ImageProvider(String name) {
-        this.name = name;
+        this.name = Objects.requireNonNull(name, "name");
     }
 
@@ -863 +866 @@
             // This method is called from different thread and modifying HashMap concurrently can result
             // for example in loops in map entries (ie freeze when such entry is retrieved)
-            if (name == null)
-                return null;
 
             String prefix = isDisabled ? "dis:" : "";
@@ -2089 +2090 @@
         return ("ImageProvider ["
                 + (dirs != null && !dirs.isEmpty() ? "dirs=" + dirs + ", " : "") + (id != null ? "id=" + id + ", " : "")
-                + (subdir != null && !subdir.isEmpty() ? "subdir=" + subdir + ", " : "") + (name != null ? "name=" + name + ", " : "")
+                + (subdir != null && !subdir.isEmpty() ? "subdir=" + subdir + ", " : "") + "name=" + name + ", "
                 + (archive != null ? "archive=" + archive + ", " : "")
                 + (inArchiveDir != null && !inArchiveDir.isEmpty() ? "inArchiveDir=" + inArchiveDir : "") + ']').replaceAll(", \\]", "]");