Changeset 13918 in osm

Timestamp:

2009-02-27T12:05:10+01:00 (16 years ago)

Author:

stoecker

Message:

fix preset handling in validator

File:

• applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/tests/TagChecker.java (modified) (1 diff)

applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/tests/TagChecker.java

@@ -369 +369 @@
             {
                 List<String> values = presetsValueData.get(key);
-                if( values != null && !values.contains(prop.getValue()) && !withErrors.contains(p, "UPV"))
-                {
-                    String i = marktr("Key ''{0}'' unknown.");
-                    errors.add( new TestError(this, Severity.OTHER, tr("Unknown property values"),
+                if( values == null)
+                {
+                    String i = marktr("Key ''{0}'' not in presets.");
+                    errors.add( new TestError(this, Severity.OTHER, tr("Presets do not contain property key"),
                     tr(i, key), MessageFormat.format(i, key), INVALID_VALUE, p) );
+                    withErrors.add(p, "UPK");
+                }
+                else if(!values.contains(prop.getValue()))
+                {
+                    String i = marktr("Value ''{0}'' for key ''{1}'' not in presets.");
+                    errors.add( new TestError(this, Severity.OTHER, tr("Presets do not contain property value"),
+                    tr(i, prop.getValue(), key), MessageFormat.format(i, prop.getValue(), key), INVALID_VALUE, p) );
                     withErrors.add(p, "UPV");
                 }