Changeset 13269 in josm for trunk/src/org

Timestamp:

2018-01-01T21:34:45+01:00 (7 years ago)

Author:

Don-vip

Message:

fix #15716 - proper exit of imagery offset mapmode

File:

• trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java (modified) (7 diffs)

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -15 +15 @@
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseEvent;
-import java.awt.event.WindowAdapter;
-import java.awt.event.WindowEvent;
 import java.util.Formatter;
 import java.util.Locale;
@@ -226 +224 @@
                     tr("Adjust imagery offset"),
                     new String[] {tr("OK"), tr("Cancel")},
-                    false);
+                    false, false); // Do not dispose on close, so HIDE_ON_CLOSE remains the default behaviour and setVisible is called
             setButtonIcons("ok", "cancel");
             contentInsets = new Insets(10, 15, 5, 15);
@@ -243 +241 @@
             setContent(pnl);
             setupDialog();
-            addWindowListener(new WindowEventHandler());
             setRememberWindowGeometry(getClass().getName() + ".geometry", WindowGeometry.centerInWindow(Main.parent, getSize()));
         }
@@ -275 +272 @@
             }
             updateOffsetIntl();
-            if (MainApplication.isDisplayingMapView()) {
-                MainApplication.getMap().repaint();
-            }
+            layer.invalidate();
         }
 
@@ -323 +318 @@
             }
             super.buttonAction(buttonIndex, evt);
-            restoreMapModeState();
         }
 
@@ -340 +334 @@
             }
             MainApplication.getMenu().imageryMenu.refreshOffsetMenu();
+            restoreMapModeState();
         }
 
@@ -349 +344 @@
                 map.selectMapMode(oldMapMode);
                 oldMapMode = null;
-            } else {
-                map.selectSelectTool(false);
-            }
-        }
-
-        class WindowEventHandler extends WindowAdapter {
-            @Override
-            public void windowClosing(WindowEvent e) {
-                setVisible(false);
-                restoreMapModeState();
+            } else if (!map.selectSelectTool(false)) {
+                exitMode();
+                map.mapMode = null;
             }
         }